Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vis_type_metric to kibana/new platform #63096

Merged
merged 8 commits into from
Apr 16, 2020
Merged

Migrate vis_type_metric to kibana/new platform #63096

merged 8 commits into from
Apr 16, 2020

Conversation

kertal
Copy link
Member

@kertal kertal commented Apr 9, 2020 •
edited
Loading

Summary

This PR moves the Metric Visualization to kibana/new platform.

Part of #60097

@kertal kertal self-assigned this Apr 9, 2020
@flash1293 flash1293 mentioned this pull request Apr 9, 2020
Closed
69 tasks
@kertal kertal force-pushed the kertal-pr-2020-04-09-vis_type_metric-kibana-platform branch from bf9e265 to debd090 Compare April 10, 2020 16:33
@kertal kertal added v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal marked this pull request as ready for review April 10, 2020 18:14
@kertal kertal requested a review from a team as a code owner April 10, 2020 18:14
@flash1293 flash1293 self-requested a review April 14, 2020 12:17
flash1293
flash1293 requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old metric_vis legacy platform plugin had a yml setting metric_vis.enabled to disable the plugin completely. The new plugin should have the same thing (and it should rename the old setting key with a warning in the logs to not introduce a breaking change in a minor version). In the timelion PR it works the same way - you need to enable the server part of the plugin for this and export the config descriptor: https://github.com/elastic/kibana/pull/62819/files#diff-c95203aabd5d12d154d7a5c2b5717967

Also please adjust the .github/CODEOWNERS file

src/plugins/vis_type_metric/kibana.json Outdated Show resolved Hide resolved
@flash1293 flash1293 mentioned this pull request Apr 14, 2020
Merged
@kertal
Copy link
Member Author

kertal commented Apr 15, 2020

The old metric_vis legacy platform plugin had a yml setting metric_vis.enabled to disable the plugin completely. The new plugin should have the same thing (and it should rename the old setting key with a warning in the logs to not introduce a breaking change in a minor version). In the timelion PR it works the same way - you need to enable the server part of the plugin for this and export the config descriptor: https://github.com/elastic/kibana/pull/62819/files#diff-c95203aabd5d12d154d7a5c2b5717967

Also please adjust the .github/CODEOWNERS file

thx joe, I've applied those changes

@kertal kertal requested review from cchaos and flash1293 April 15, 2020 10:38
cchaos
cchaos approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

flash1293
flash1293 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and everything works as expected (metrics rendered correctly, possible to disable them via config key)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit 5ffdeb6 into elastic:master Apr 16, 2020
kertal added a commit to kertal/kibana that referenced this pull request Apr 16, 2020
@kertal
Migrate vis_type_metric to kibana/new platform (elastic#63096)
ad5026f 
* Move vis_type_metric to Kibana Platform

* Adapt i18n

* Cleanup tests

* Modify CODEOWNERS

* Cleanup SCSS
@kertal kertal mentioned this pull request Apr 16, 2020
Merged
kertal added a commit that referenced this pull request Apr 17, 2020
@kertal
Migrate vis_type_metric to kibana/new platform (#63096) (#63690)
5ea0628 
* Move vis_type_metric to Kibana Platform

* Adapt i18n

* Cleanup tests

* Modify CODEOWNERS

* Cleanup SCSS
@kertal kertal deleted the kertal-pr-2020-04-09-vis_type_metric-kibana-platform branch August 3, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@cchaos cchaos cchaos approved these changes

Assignees

@kertal kertal

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kertal @elasticmachine @kibanamachine @cchaos @flash1293