Move files, add README, replace implicit any with stricter types. Reorganize types.
#63262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 10, 2020 12:35
* rename file to match component * remove unused exports * make singleton array immutable
…ference to private repo
…app types. add README
Co-Authored-By: kqualters-elastic <56408403+kqualters-elastic@users.noreply.github.com>
oatkiller
added
Feature:Endpoint
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
oatkiller
requested review from
paul-tavares,
kevinlog,
james-elastic and
peluja1012
dplumlee
approved these changes
Apr 10, 2020
paul-tavares
approved these changes
Apr 10, 2020
| @@ -319,3 +322,25 @@ export interface AlertingIndexUIQueryParams { | |||
| date_range?: string; | |||
| filters?: string; | |||
| } | |||
|
|
|||
| export interface GetDatasourcesResponse { | |||
There was a problem hiding this comment.
Can you add the comment back on these that references the kibana issue? I will likely implement it early next week in Ingest and will then refactor the code here to use them since we should really not be defining our own API response interface for ingest APIs
There was a problem hiding this comment.
Are you fine if I instead link to the code from the issue?
There was a problem hiding this comment.
Sure, that's fine 😃
(FYI - the issues I referenced in the todo comment were public and not to private repos)
| /** | ||
| * The PageId type is used for the payload when firing userNavigatedToPage actions | ||
| */ | ||
| export type PageId = 'alertsPage' | 'managementPage' | 'policyListPage'; |
There was a problem hiding this comment.
FYI - with the PR I'm working on now, I should be able to delete this along with the hook that uses it. :)
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
oatkiller
pushed a commit
to oatkiller/kibana
that referenced
this pull request
Apr 13, 2020
…r types. Reorganize types. (elastic#63262) * Removed `FIXME` comments and references to private repos. Please use Github issues to track work * Added a README describing the modules in `applications/endpoint` * Removed dead code * Moved `AppRoot` component to its own module * Moved `applications/endpoint/services` under `store` * Moved some exported types to `applications/endpoint/types` * Moved all React code to `view` * Added types in some places that were implicitly `any` * Moved `PageId` type from common directory (where it could be shared with the server) to the public directory Conflicts: * `x-pack/plugins/endpoint/public/applications/endpoint/view/policy/policy_details.tsx`
oatkiller
pushed a commit
that referenced
this pull request
Apr 13, 2020
…r types. Reorganize types. (#63262) (#63363) * Removed `FIXME` comments and references to private repos. Please use Github issues to track work * Added a README describing the modules in `applications/endpoint` * Removed dead code * Moved `AppRoot` component to its own module * Moved `applications/endpoint/services` under `store` * Moved some exported types to `applications/endpoint/types` * Moved all React code to `view` * Added types in some places that were implicitly `any` * Moved `PageId` type from common directory (where it could be shared with the server) to the public directory Conflicts: * `x-pack/plugins/endpoint/public/applications/endpoint/view/policy/policy_details.tsx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FIXMEcomments and references to private repos. Please use Github issues to track workapplications/endpointAppRootcomponent to its own moduleapplications/endpoint/servicesunderstoreapplications/endpoint/typesviewanyPageIdtype from common directory (where it could be shared with the server) to the public directoryChecklist
There were no intended changes.
For maintainers