Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build #63486

Merged
merged 8 commits into from
Apr 24, 2020
Merged

chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build #63486

merged 8 commits into from
Apr 24, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 14, 2020

That solves a deprecation warning that was being logged during the canvas build: @babel/polyfill is deprecated. Please, use required parts of core-js and regenerator-runtime/runtime separately.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.7.1 labels Apr 14, 2020
@mistic mistic requested a review from a team as a code owner April 14, 2020 16:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Apr 15, 2020

@elasticmachine merge upstream

@crob611
Copy link
Contributor

crob611 commented Apr 17, 2020

@mistic When I run this, it give me an error Uncaught ReferenceError: regeneratorRuntime is not defined

If you want to test that any changes you make are working, you can extract the included file and can drop the built kbn_canvas.js in there and serve up that index.html. Should see an embedded workpad if everything is working properly.

canvas-workpad-embed.zip

@mistic
Copy link
Member Author

mistic commented Apr 17, 2020

@elasticmachine merge upstream

spalger
spalger approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spalger
spalger suggested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't see the comment from @crob611, maybe we should add regenerator-runtime/runtime?

@spalger
Copy link
Contributor

spalger commented Apr 17, 2020 •
edited
Loading

There are a number of polyfills defined in @kbn/ui-shared-deps/polyfills that aren't here... But I also wonder if we should be embedding polyfills or supply a build of the sharable runtime with and without them...

@mistic
Copy link
Member Author

mistic commented Apr 17, 2020

@crob611 I forgot to add the regenerator-runtime/runtime previously, thanks for the example, now it's working. @spalger I believe we only need to include the core-js, the regenerator-runtime/runtime and the whatwg-fetch for now. Do you think we should add the same polyfill group we are using for ui-shared-deps?

@spalger
Copy link
Contributor

spalger commented Apr 17, 2020

Do you think we should add the same polyfill group we are using for ui-shared-deps?

I'm not sure, I think that's a design decision

@mistic
Copy link
Member Author

mistic commented Apr 20, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Apr 20, 2020

everything seems to be working well now

spalger
spalger approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member Author

mistic commented Apr 22, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 34de1ae into elastic:master Apr 24, 2020
@spalger spalger mentioned this pull request Apr 24, 2020
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 24, 2020
@mistic @elasticmachine @spalger
chore(NA): use core-js instead of babel-polyfill on canvas sha… (elas…
5ea6cf4 
…tic#63486)

* chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build

* chore(NA): include regenerator-runtime/runtime

* chore(NA): change import order between runtime and core js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger mentioned this pull request Apr 24, 2020
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 24, 2020
@mistic @elasticmachine @spalger
chore(NA): use core-js instead of babel-polyfill on canvas sha… (elas…
8e95f5d 
…tic#63486)

* chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build

* chore(NA): include regenerator-runtime/runtime

* chore(NA): change import order between runtime and core js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Apr 24, 2020
@mistic @elasticmachine
chore(NA): use core-js instead of babel-polyfill on canvas sha… (#63486…
7041deb 
…) (#64385)

* chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build

* chore(NA): include regenerator-runtime/runtime

* chore(NA): change import order between runtime and core js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Apr 24, 2020
@mistic @elasticmachine
chore(NA): use core-js instead of babel-polyfill on canvas sha… (#63486…
0338f8e 
…) (#64386)

* chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build

* chore(NA): include regenerator-runtime/runtime

* chore(NA): change import order between runtime and core js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 24, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
7b89039 
* master: (70 commits)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  [ML] Changes transforms wizard UI text (elastic#64150)
  [Alerting] change server log action type .log to .server-log in README (elastic#64124)
  [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026)
  chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269)
  chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486)
  skip flaky suite (elastic#61173)
  skip flaky suite (elastic#62497)
  Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262)
  [eslint] no_restricted_paths config cleanup (elastic#63741)
  Add Oil Rig Icon from @elastic/maki (elastic#64364)
  [Maps] Migrate Maps embeddables to NP (elastic#63976)
  [Ingest] Data streams list page (elastic#64134)
  chore(NA): add file-loader into jest moduleNameMapper (elastic#64330)
  [DOCS] Added images to automating report generation (elastic#64333)
  [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948)
  Expose ability to check if API Keys are enabled (elastic#63454)
  [DOCS] Fixes formatting in alerting doc (elastic#64338)
  [data.search.aggs]: Create agg types function for terms agg. (elastic#63541)
  ...
spalger added a commit that referenced this pull request Apr 29, 2020
@spalger
Revert "chore(NA): use core-js instead of babel-polyfill on canvas sh…
527ea3f 
…a… (#63486) (#64386)"

This reverts commit 0338f8e.
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 29, 2020
@mistic @elasticmachine @spalger
chore(NA): use core-js instead of babel-polyfill on canvas sha… (elas…
4e9df85 
…tic#63486)

* chore(NA): use core-js instead of babel-polyfill on canvas shareable runtime build

* chore(NA): include regenerator-runtime/runtime

* chore(NA): change import order between runtime and core js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @crob611 @spalger @kibanamachine