[Lens] Split apart config panel component to more manageable chunks #63910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
commented
Apr 17, 2020
| @@ -72,6 +72,10 @@ export const xyVisualization: Visualization<State, PersistableState> = { | |||
| return state.layers.map(l => l.layerId); | |||
| }, | |||
|
|
|||
| canAppendLayer(state) { | |||
| return state.layers.length < 2; | |||
| }, | |||
There was a problem hiding this comment.
I should probably take this behavior change out into a separate PR
x-pack/plugins/lens/public/types.ts
Outdated
| removeLayer?: (state: T, layerId: string) => T; | ||
| /** When function is provided and returns true, multiple layers can be added */ | ||
| canAppendLayer?: (state: T) => boolean; |
There was a problem hiding this comment.
This is an added function
| ))} | ||
| {activeVisualization.canAppendLayer && | ||
| activeVisualization.appendLayer && | ||
| activeVisualization.canAppendLayer(visualizationState) && ( |
There was a problem hiding this comment.
This line here is a behavioral change
|
@elasticmachine merge upstream |
|
Tested max. 2 layers behavior limit and how it will behave for already saved >2 layers visualization (more than 2 layers can be deleted but cannot be re-created). Looks good. |
mbondyra
approved these changes
Apr 20, 2020
cchaos
reviewed
Apr 21, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Apr 22, 2020
…lastic#63910) * [Lens] Split apart config panel component to more manageable chunks * Moving around and renaming SASS appropriately * Remove layer limit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co>
wylieconlon
pushed a commit
that referenced
this pull request
Apr 23, 2020
…63910) (#64256) * [Lens] Split apart config panel component to more manageable chunks * Moving around and renaming SASS appropriately * Remove layer limit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is setting up for work on the Y-axis formatting options.