[Reporting/telemetry] Add 'statuses' object to usage to show status counts by jobType & appType #63922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
changed the title
tsullivan
added
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
tsullivan
commented
Apr 21, 2020
|
|
||
| type AggregationKeys = 'jobTypes' | 'layoutTypes' | 'objectTypes' | 'statusTypes'; | ||
| export type AggregationResults = { [K in AggregationKeys]: AggregationBuckets } & { | ||
| export interface AggregationResultBuckets { |
There was a problem hiding this comment.
There are a lot of Typescript changes in this PR, because the previous AggregationResults type was taking a few "shortcuts" that made it difficult to build more to it. Therefore it has been replaced with AggregationResultBuckets
tsullivan
commented
Apr 22, 2020
| jobTypes: { | ||
| terms: { field: JOB_TYPES_FIELD, size: DEFAULT_TERMS_SIZE }, | ||
| aggs: { | ||
| appNames: { terms: { field: OBJECT_TYPES_FIELD, size: DEFAULT_TERMS_SIZE } }, // NOTE Discover/CSV export is missing the 'meta.objectType' field, so Discover/CSV results are missing for this agg |
There was a problem hiding this comment.
To make it clear, this aggregation is not supporting metrics for the way we store CSV reports, but all the other types of reports are supported.
See the Jest snapshot for what it looks like for CSV
poffdeluxe
approved these changes
Apr 23, 2020
x-pack/legacy/plugins/reporting/server/usage/get_reporting_usage.ts
Outdated
Show resolved
Hide resolved
timductive
approved these changes
Apr 24, 2020
joelgriffith
approved these changes
Apr 27, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 27, 2020
…ounts by jobType & appType (elastic#63922) * [Reporting] Additional status by app data for usage * --wip-- [skip ci] * clean up types * add a prettier-ignore * fix types * --wip-- [skip ci] * fix typo * more tests * Tweak the data model * fix the comments and type keys to reflect the data model Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 27, 2020
…ounts by jobType & appType (#63922) (#64551) * [Reporting] Additional status by app data for usage * --wip-- [skip ci] * clean up types * add a prettier-ignore * fix types * --wip-- [skip ci] * fix typo * more tests * Tweak the data model * fix the comments and type keys to reflect the data model Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows a request from @elastic/kibana-canvas to have Reporting usage data show the status type per app integration.
Example:
NOTE: CSV numbers are not available for the type of search aggregation being used. The reason is CSV Job parameters are missing the
meta.objectType.keywordfield which should be populated withdiscoverat CSV job creation time. Issue: #64119Checklist
For maintainers