[ESUI] Move authz lib out of snapshot restore #63947

jloleysens · 2020-04-20T09:35:48Z

Summary

Move the Authz lib to a shared place so that, for instance, the ingest pipelines app can use it. This contribution was extracted from #63850.

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

elasticmachine · 2020-04-20T09:35:51Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

kibanamachine · 2020-04-20T11:21:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5edd3be

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga

LGTM! Thanks for doing this @jloleysens! I haven't tested locally but no logic has been touched in S&R apart from imports apart from changing imports and using a custom hook 👍

sebelga · 2020-04-21T08:37:43Z

.../plugins/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx

 import { useServices } from '../../../app_context';
 import { DEFAULT_POLICY_SCHEDULE, DEFAULT_POLICY_FREQUENCY } from '../../../constants';
 import { useLoadRepositories } from '../../../services/http';
 import { linkToAddRepository } from '../../../services/navigation';
 import { documentationLinksService } from '../../../services/documentation';
-import { SectionLoading, SectionError } from '../../';
+import { SectionLoading } from '../../';


I am not seeing in the diff that the SectionError file has been deleted, did I miss it?

Here is the section_error diff

diff --git a/x-pack/plugins/snapshot_restore/public/application/components/section_error.tsx b/src/plugins/es_ui_shared/__packages_do_not_import__/authorization/components/section_error.tsx similarity index 54% rename from x-pack/plugins/snapshot_restore/public/application/components/section_error.tsx rename to src/plugins/es_ui_shared/__packages_do_not_import__/authorization/components/section_error.tsx index bd9e487967..3d56309ada 100644 --- a/x-pack/plugins/snapshot_restore/public/application/components/section_error.tsx +++ b/src/plugins/es_ui_shared/__packages_do_not_import__/authorization/components/section_error.tsx @@ -1,7 +1,20 @@ /* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License; - * you may not use this file except in compliance with the Elastic License. + * Licensed to Elasticsearch B.V. under one or more contributor + * license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright + * ownership. Elasticsearch B.V. licenses this file to you under + * the Apache License, Version 2.0 (the "License"); you may + * not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. */ import { EuiCallOut, EuiSpacer } from '@elastic/eui';

sebelga · 2020-04-21T08:42:51Z

src/plugins/es_ui_shared/public/index.ts

@@ -47,6 +47,18 @@ export {
  expandLiteralStrings,
 } from './console_lang';

+export {


To avoid naming collisions, the idea was not to export from the top-level index.ts. For example, here we might probably export another Error interface in a different context.

Right, that is something I am meaning to address properly in future. A smart refactor tool should do the heavy lifting for us when we move that folder.

I created this issue for discussion though: #64052

Awesome thanks for opening the issue! 👍

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

…t-node-pipelines * 'master' of github.com:elastic/kibana: (32 commits) Move authz lib out of snapshot restore (#63947) Migrate vis_type_table to kibana/new platform (#63105) Enable include/exclude in Terms agg for numeric fields (#59425) follow conventions for saved object definitions (#63571) [Docs]Adds saved object key setting to load balancing kib instances (#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (#63838) Fix page layouts, clean up unused code (#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (#63859) [Maps] Do not fetch geo_shape from docvalues (#63997) Vega doc changes (#63889) [Metrics UI] Reorganize file layout for Metrics UI (#60049) Add sub-menus to Resolver node (for 75% zoom) (#63476) [FTR] Add test suite metrics tracking/output (#62515) [ML] Fixing single metric viewer page padding (#63839) [Discover] Allow user to generate a report after saving a modified saved search (#63623) [Reporting] Config flag to escape formula CSV values (#63645) [Metrics UI] Remove remaining field filtering (#63398) [Maps] fix date labels (#63909) [TSVB] Use default Kibana palette for split series (#62241) ...

…bana into ingest-node-pipelines/privileges * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) ... # Conflicts: # x-pack/legacy/plugins/uptime/public/components/monitor/ml/index.ts # x-pack/legacy/plugins/uptime/public/components/overview/index.ts # x-pack/plugins/ingest_pipelines/public/application/index.tsx # x-pack/plugins/ingest_pipelines/server/routes/api/index.ts # x-pack/plugins/ingest_pipelines/server/routes/index.ts

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) [Ingest Node Pipelines] Clone Pipeline (elastic#64049) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) ...

Move authz lib out of snapshot restore

5edd3be

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

jloleysens added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 20, 2020

jloleysens requested review from sebelga and alisonelizabeth April 20, 2020 09:35

jloleysens requested a review from a team as a code owner April 20, 2020 09:35

jloleysens mentioned this pull request Apr 20, 2020

[Ingest node pipelines] Privileges #63850

Merged

sebelga approved these changes Apr 21, 2020

View reviewed changes

jloleysens merged commit 1deb5d6 into elastic:master Apr 21, 2020

jloleysens deleted the es-ui-shared/authz-lib branch April 21, 2020 10:31

jloleysens mentioned this pull request Apr 21, 2020

[7.x] Move authz lib out of snapshot restore (#63947) #64053

Merged

jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 21, 2020

Move authz lib out of snapshot restore (elastic#63947)

b0b26f6

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

jloleysens added a commit that referenced this pull request Apr 21, 2020

Move authz lib out of snapshot restore (#63947) (#64053)

360ff77

Created the first entry for the new __packages_do_no_import__ folder that will house ESUIs private packages.

alisonelizabeth mentioned this pull request Dec 15, 2020

Refining UX around user privileges #86016

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ESUI] Move authz lib out of snapshot restore #63947

[ESUI] Move authz lib out of snapshot restore #63947

jloleysens commented Apr 20, 2020 •

edited

Loading

elasticmachine commented Apr 20, 2020

kibanamachine commented Apr 20, 2020

sebelga left a comment

sebelga Apr 21, 2020

jloleysens Apr 21, 2020

sebelga Apr 21, 2020

jloleysens Apr 21, 2020

sebelga Apr 22, 2020

[ESUI] Move authz lib out of snapshot restore #63947

[ESUI] Move authz lib out of snapshot restore #63947

Conversation

jloleysens commented Apr 20, 2020 • edited Loading

Summary

elasticmachine commented Apr 20, 2020

kibanamachine commented Apr 20, 2020

💚 Build Succeeded

sebelga left a comment

Choose a reason for hiding this comment

sebelga Apr 21, 2020

Choose a reason for hiding this comment

jloleysens Apr 21, 2020

Choose a reason for hiding this comment

sebelga Apr 21, 2020

Choose a reason for hiding this comment

jloleysens Apr 21, 2020

Choose a reason for hiding this comment

sebelga Apr 22, 2020

Choose a reason for hiding this comment

jloleysens commented Apr 20, 2020 •

edited

Loading