[kbn clean] delete plugin target directories #64016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tylersmalley
approved these changes
Apr 27, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Apr 28, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Apr 28, 2020
spalger
pushed a commit
that referenced
this pull request
Apr 28, 2020
spalger
pushed a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had assumed that
@kbn/pmwould automatically clear thetargetdirectories out of the plugins because it seemed to be aware of them in the project graph, but unless they have a meaningful package.json file they aren't considered to be projects and as such won't have their build directories cleaned, so instead I've added their target directories to the list of extra patterns to delete onyarn kbn cleanfor the kibana and x-pack projects.