-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nav #64018
Merged
Merged
New nav #64018
Changes from 29 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
3aaeefe
Fix height calc to use correct EUI variable
MichaelMarcialis b315034
collapsible nav
23eeebc
fixing PR feedback
90e537b
updated category public api
ebfa324
fixing first few tests
84b3f2b
undoing visualize->visualization library naming
91fcde6
move recently viewed to the top
b35eacc
hotfix apps sometimes displaying a scrollbar
811cde3
fix euiBottomBar width calculation
7b8a016
translation file fix
ea92cd7
displaying links without a category
2875a35
more test fixed
affb4d9
Merge remote-tracking branch 'upstream/master' into new-nav
d1259c5
Revert "fix euiBottomBar width calculation"
2f3a1cf
better todo naming
aec8305
safely migrate bottomBar width to new nav widths
27531e6
addressing feedback from @pgayvallet
86fb664
fix visualization full screen issues
bbb0a33
fixing more tests
04fea87
fixing painless lab bottombar popover
9591a6f
pass onclick to nav items without category
9568d18
documenting category id and getNavType
31eec3e
Merge remote-tracking branch 'upstream/master' into new-nav
7c16e3a
fixing more tests
1f84027
fixing width overflow with legacy nav
MichaelMarcialis 21e6255
additional test fixes
4891ee9
updating EUI to 22.3.1
421e687
fixing more tests...
1cc0fb5
fixing jest + a11y tests
283d9d0
fixing more jest + a11y tests
216cac8
Merge remote-tracking branch 'upstream/master' into new-nav
975b08c
Merge branch 'master' into new-nav
elasticmachine 4bc97a7
Merge branch 'master' into new-nav
elasticmachine 86f7830
Merge branch 'master' into new-nav
elasticmachine 797dfa9
jest + a11y tests fixes
757df00
fixing plugin categories
dbb49a0
Merge remote-tracking branch 'upstream/master' into new-nav
b612739
fixing the last remaining tests, I hope
bf1b6ee
fixing discvoer test failure
1fe8bb9
implementing PR feedback and adding basic test coverage
08d83d5
Merge remote-tracking branch 'upstream/master' into new-nav
db25a51
fixing schema failure
7c61b6c
fixing canvas category type
d7f1ba1
Merge remote-tracking branch 'upstream/master' into new-nav
ca23f13
Merge remote-tracking branch 'upstream/master' into new-nav
2d57e30
Merge remote-tracking branch 'upstream/master' into new-nav
96bf7c0
attempting to fix a merge conflict
5dbc9c8
fixing react types because yarn is having a hard time
153cf49
Merge remote-tracking branch 'upstream/master' into new-nav
a947add
Merge remote-tracking branch 'upstream/master' into new-nav
485a4ee
fix DEFAULT_APP_CATEGORIES import
02dac24
update public api
4690a2f
Merge remote-tracking branch 'upstream/master' into new-nav
9c98447
Merge remote-tracking branch 'upstream/master' into new-nav
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
docs/development/core/public/kibana-plugin-core-public.appcategory.id.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [AppCategory](./kibana-plugin-core-public.appcategory.md) > [id](./kibana-plugin-core-public.appcategory.id.md) | ||
|
||
## AppCategory.id property | ||
|
||
Unique identifier for the categories | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
id: string; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
docs/development/core/public/kibana-plugin-core-public.chromestart.getnavtype_.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [ChromeStart](./kibana-plugin-core-public.chromestart.md) > [getNavType$](./kibana-plugin-core-public.chromestart.getnavtype_.md) | ||
|
||
## ChromeStart.getNavType$() method | ||
|
||
Get the navigation type TODO \#64541 Can delete | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
getNavType$(): Observable<NavType>; | ||
``` | ||
<b>Returns:</b> | ||
|
||
`Observable<NavType>` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
docs/development/core/public/kibana-plugin-core-public.navtype.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [NavType](./kibana-plugin-core-public.navtype.md) | ||
|
||
## NavType type | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
export declare type NavType = 'modern' | 'legacy'; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this doing the same thing that the
showButtonIfDocked
prop does onEuiCollapsibleNav
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... If I was using the button supplied by
EuiCollapsibleNav
... Because of the stuff on the right of the header, I'm using my own button to keep focus order predictable. (Using the button supplied by EUI makes the focus order ToggleButton -> Nav down the left -> Header -> Rest of the page; With a custom button the order is Header -> Nav down the left -> Rest of the page.)I don't think there's a way that EUI can do this for us and is a reasonable default for them but is flexible enough for Kibana.