Extended existing alerting functionality to support preconfigured only action types #64030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
approved these changes
Apr 21, 2020
mikecote
requested changes
Apr 22, 2020
There was a problem hiding this comment.
It seems the pre-configured only actions don't run on the server side, I get the following error:
server log [09:34:19.767] [warning][alerting][alerting][plugins][plugins] Alert "3ba5d2d2-12fb-40db-8ed6-a7b4741a56ba" skipped scheduling action "log" because it is disabled
This could be worth an API Integration test to ensure pre-configured only action types work.
It also seems that the sort order is off when mixing pre-configured only action types in the alert flyout (the clickable ones should be first and ordered alphabetically). Below only "Index" and "Server Log" are clickable:
mikecote
reviewed
Apr 22, 2020
There was a problem hiding this comment.
So far the remaining from my previous review LGTM, great work! I will defer to @gchaps to review the docs portion. Maybe there's something in common between the docs for preconfigured action types and the docs for preconfigured connectors.
x-pack/plugins/triggers_actions_ui/public/application/lib/check_action_type_enabled.tsx
Outdated
Show resolved
Hide resolved
…y-action-types # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
gchaps
reviewed
Apr 22, 2020
mikecote
reviewed
Apr 23, 2020
There was a problem hiding this comment.
Getting close, looks like there's two more places on the server side that need to allow preconfigured actions and they should run afterwards.
I use the following test scenario to see if a preconfigured action works:
- Disable the
.server-logaction type by removing it fromxpack.actions.enabledActionTypes - Create a preconfigured server log action type within
xpack.actions.preconfigured - Create an alert where
.kibana_task_managercount is below 1000 and send a server log (preconfigured) as the action - Wait for message to display
x-pack/plugins/alerting/server/task_runner/create_execution_handler.ts
Outdated
Show resolved
Hide resolved
mikecote
approved these changes
Apr 24, 2020
…preconfigured list
…y-action-types # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 24, 2020
…y action types (elastic#64030) * Extended existing alerting functionality to support preconfigured only action types * fixed functional test * Adding documentation * Fixed UI part due to comments * added missing tests * fixed action type execution * Fixed documentation * Fixed due to comments * fixed type checks * extended isActionExecutable to check exact action id if it is in the preconfigured list
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 25, 2020
…y action types (elastic#64030) * Extended existing alerting functionality to support preconfigured only action types * fixed functional test * Adding documentation * Fixed UI part due to comments * added missing tests * fixed action type execution * Fixed documentation * Fixed due to comments * fixed type checks * extended isActionExecutable to check exact action id if it is in the preconfigured list
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 27, 2020
…y action types (elastic#64030) * Extended existing alerting functionality to support preconfigured only action types * fixed functional test * Adding documentation * Fixed UI part due to comments * added missing tests * fixed action type execution * Fixed documentation * Fixed due to comments * fixed type checks * extended isActionExecutable to check exact action id if it is in the preconfigured list
YulNaumenko
added a commit
that referenced
this pull request
Apr 27, 2020
…y action types (#64030) (#64525) * Extended existing alerting functionality to support preconfigured only action types * fixed functional test * Adding documentation * Fixed UI part due to comments * added missing tests * fixed action type execution * Fixed documentation * Fixed due to comments * fixed type checks * extended isActionExecutable to check exact action id if it is in the preconfigured list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #63166
Extend existing UI to be able to support preconfigured action types.
Current functionality is based on skipping preconfigured action type in
xpack.actions.enabledActionTypes: ['.server-log', '.email', '.index']and having only preconfigured connectors of this action type:xpack.actions.preconfigured:- id: 'my-slack1' # action/connector idactionTypeId: .slack #use the built in slack action typename: 'Slack #xyz'# sensitive config like secrets are preferably stored in Kibana keystoreconfig:webhookUrl: 'https://hooks.slack.com/services/abcd/efgh/ijklmnopqrstuvwxyz'User shouldn't be able to create a connector of preconfigured action type:
But still should have an option to attach the preconfigured connectors to an alert: