Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern management - field list - localization functions returning empty strings #64055

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 21, 2020

Closes: #63649

Summary

The index pattern management field list should look like this -
Screen Shot 2020-04-15 at 5 07 55 PM

but it looks like this -
Screen Shot 2020-04-15 at 5 35 31 PM

Root cause:

i18n directive uses the $sanitize service from the ngSanitize module. For correct building of the dependency tree, please do not forget to specify all the necessary modules during the declaration of your module.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added the bug Fixes for quality problems that affect the customer experience label Apr 21, 2020
@alexwizp alexwizp marked this pull request as ready for review April 21, 2020 11:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n directive uses the $sanitize service from the ngSanitize module. For correct building of the dependency tree, please do not forget to specify all the necessary modules during the declaration of your module.

Was it always broken or did some changes introduce a regression?

@alexwizp
Copy link
Contributor Author

Now it is very difficult to say. I definitely see the problem in this file. I think this worked before because some of the parent module used the ngSanitize dependency.

alexwizp added a commit that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:NP Migration release_note:fix v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index pattern management - field list - localization functions returning empty strings
6 participants