Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Global search API #64284

Merged
merged 21 commits into from
May 18, 2020
Merged

[RFC] Global search API #64284

merged 21 commits into from
May 18, 2020

Commits on Apr 23, 2020

  1. initial file import

    @pgayvallet
    pgayvallet committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    86d6ce4 View commit details
    Browse the repository at this point in the history

  2. update types

    @pgayvallet
    pgayvallet committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    2aa6e80 View commit details
    Browse the repository at this point in the history

  3. update RFC PR number

    @pgayvallet
    pgayvallet committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6bdc15f View commit details
    Browse the repository at this point in the history

  4. first draft complete

    @pgayvallet
    pgayvallet committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    b3a31fa View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. draft v1.1.0

    @pgayvallet
    pgayvallet committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    6971597 View commit details
    Browse the repository at this point in the history

  2. initial self review

    @pgayvallet
    pgayvallet committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    2e1c006 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. nits and comments

    @pgayvallet
    pgayvallet committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    cc473fe View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. add 'preference' option

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    cbdc44c View commit details
    Browse the repository at this point in the history

  2. change meta type to Record<string, Serializable>

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    5d6e4cb View commit details
    Browse the repository at this point in the history

  3. specify cancellation

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    3a094aa View commit details
    Browse the repository at this point in the history

  4. remove generic for GlobalSearchResponse, use distinct type on client … 

    …and server
    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    5d750e0 View commit details
    Browse the repository at this point in the history

  5. use plain string instead of enum for GlobalSearchResult.type

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    24b1ec3 View commit details
    Browse the repository at this point in the history

  6. remove terminology from unresolved questions

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    15ece40 View commit details
    Browse the repository at this point in the history

  7. update pros/cons of core vs plugin

    @pgayvallet
    pgayvallet committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    0987e0d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. GS is exposed from a plugin instead of core

    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    8180c3a View commit details
    Browse the repository at this point in the history

  2. remove the server.publicAddress proposal, return mixed abs url / rel … 

    …paths instead
    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    aed714f View commit details
    Browse the repository at this point in the history

  3. distinguish result type between GS api and result providers

    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    9bf9231 View commit details
    Browse the repository at this point in the history

  4. return batched results, no longer sort

    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    d2289f7 View commit details
    Browse the repository at this point in the history

  5. remove request from GlobalSearchProviderContext

    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    66d6db9 View commit details
    Browse the repository at this point in the history

  6. add maxResults to GlobalSearchProviderFindOptions

    @pgayvallet
    pgayvallet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    3de606a View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. nit/typo

    @pgayvallet
    pgayvallet committed May 11, 2020
    Configuration menu
    Copy the full SHA
    fc6bf13 View commit details
    Browse the repository at this point in the history