ES UI new platform cleanup #64332

cjcenizal · 2020-04-23T17:03:08Z

This PR removes the stub remote_clusters, index_management, and upgrade_assistant legacy plugins. Changes to note:

Remote clusters had some styles which I moved to the NP plugin.
I migrated the saved object types from uiExports per Allow savedObjects types registration from NP #57430

elasticmachine · 2020-04-23T17:03:10Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal · 2020-04-23T17:05:03Z

@cchaos I understand the reasoning behind extracting styles out of the root index.scss file and having them live next to the components that own them but in cases like these, where we have only a couple tightly-focused hacks, I think it's better to keep them in a central location where it's easier to discover them (and remove them once the're no longer necessary).

cchaos · 2020-04-23T17:44:25Z

When they are hacks, we actually use a file named _hacks.scss. Example: https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/management/_hacks.scss

cjcenizal · 2020-04-23T18:40:33Z

@jloleysens Could you take a look at the Upgrade Assistant changes (91957739bf40aa9803dd11a24983ecf91ad770d3)? I'm not sure how to test these.

@pgayvallet Could you take a look at my change to SavedObjectsCoreFieldMapping?

…es to NP plugin. - Update SavedObjectsCoreFieldMapping with null_field parameter.

cjcenizal · 2020-04-23T19:36:57Z

Thanks for tip, @cchaos! Can you take another look?

cchaos

Sure, that's fine

joshdover

Code LGTM! FYI you'll need to regenerate and commit the core API docs:

node scripts/check_published_api_changes.js --docs --accept --filter=core/server

cjcenizal · 2020-04-23T23:09:26Z

Thanks @joshdover, done.

cjcenizal · 2020-04-24T18:37:42Z

...k/plugins/upgrade_assistant/server/saved_object_types/reindex_operation_saved_object_type.ts

+  name: REINDEX_OP_TYPE,
+  hidden: false,
+  namespaceType: 'agnostic',
+  mappings: {


The new Saved Object types API disallows dynamic mapping, which the original type definitions depended upon, so I had to add a bunch of new mappings to get the tests passing.

If dynamic mappings in SO type are really a need, we can discuss about enabling it (actually it's only 'disabled' in the TS type, forcing the dynamic: true value does work, see (but please don't do):

kibana/src/core/server/ui_settings/saved_objects/ui_settings.ts

Lines 27 to 30 in d72de0e

// we don't want to allow `true` in the public `SavedObjectsTypeMappingDefinition` type, however

// this is needed for the config that is kinda a special type. To avoid adding additional internal types

// just for this, we hardcast to any here.

dynamic: true as any,

It's just that when we discussed about it, we did not find any valid argument to allow this value on the public API as a SO type mapping is meant to be exhaustive.

Thanks Pierre! I don't think we need it in this case. I also created #64547 so that we eventually remove these added mappings (if possible).

pgayvallet · 2020-04-27T06:30:29Z

...k/plugins/upgrade_assistant/server/saved_object_types/reindex_operation_saved_object_type.ts

+  name: REINDEX_OP_TYPE,
+  hidden: false,
+  namespaceType: 'agnostic',
+  mappings: {


If dynamic mappings in SO type are really a need, we can discuss about enabling it (actually it's only 'disabled' in the TS type, forcing the dynamic: true value does work, see (but please don't do):

kibana/src/core/server/ui_settings/saved_objects/ui_settings.ts

Lines 27 to 30 in d72de0e

// we don't want to allow `true` in the public `SavedObjectsTypeMappingDefinition` type, however

// this is needed for the config that is kinda a special type. To avoid adding additional internal types

// just for this, we hardcast to any here.

dynamic: true as any,

It's just that when we discussed about it, we did not find any valid argument to allow this value on the public API as a SO type mapping is meant to be exhaustive.

cjcenizal · 2020-04-27T21:54:46Z

I tested UA by verifying that the sample telemetry data shown in Advanced Settings included UA data that reflected actions I've taken in the UI. I also stubbed out some server code to allow me to reindex sample data:

const getCombinedIndexInfos = (deprecations: DeprecationAPIResponse) => ([{
  index: 'kibana_sample_data_flights',
  reindex: true
}]);

This let me run the reindexing action in the UI and verify that it completed successfully.

jloleysens

Changes look good to me, happy if CI is passing.

…rted.

kibanamachine · 2020-04-28T16:18:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3115da0

History

💔 Build #43726 failed 2ed99c6
💚 Build #43495 succeeded 0f7ce01
💚 Build #43160 succeeded 6d70a6a
💔 Build #42933 failed 1cd73b3
💔 Build #42867 failed 5492849

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timestamp

* master: (60 commits) [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) [Uptime] Update uptime ml job id to limit to 64 char (elastic#64394) [Ingest] Fix GET /enrollment-api-keys/null error (elastic#64595) Consolidate cross-cutting concerns between region & coordinate maps in new maps_legacy plugin (elastic#64123) ES UI new platform cleanup (elastic#64332) [Event Log] use @timestamp field for queries (elastic#64391) ...

cjcenizal added 2 commits April 23, 2020 09:54

Remove stub legacy index_management plugin.

3e8f340

Remove stub legacy remote_clusters plugin and move styles to NP plugin.

91b332b

cjcenizal requested a review from sebelga April 23, 2020 17:03

cjcenizal requested review from a team as code owners April 23, 2020 17:03

cjcenizal requested a review from cchaos April 23, 2020 17:03

cjcenizal requested a review from a team as a code owner April 23, 2020 18:39

cjcenizal requested review from pgayvallet and jloleysens April 23, 2020 18:40

cjcenizal added 2 commits April 23, 2020 12:34

Remove stub legacy upgrade_assistant plugin and move saved object typ…

28b8172

…es to NP plugin. - Update SavedObjectsCoreFieldMapping with null_field parameter.

Rename hacks.scss.

5492849

cjcenizal force-pushed the np/es-ui-cleanup branch from 9195773 to 5492849 Compare April 23, 2020 19:34

cchaos approved these changes Apr 23, 2020

View reviewed changes

joshdover approved these changes Apr 23, 2020

View reviewed changes

Update core API docs.

1cd73b3

cjcenizal added 2 commits April 24, 2020 09:26

Use UA constants to define saved object type names.

fb74c85

Fix UA test failures by adding missing mappings.

6d70a6a

cjcenizal commented Apr 24, 2020

View reviewed changes

cjcenizal added the Feature:Upgrade Assistant label Apr 24, 2020

pgayvallet approved these changes Apr 27, 2020

View reviewed changes

cjcenizal mentioned this pull request Apr 27, 2020

Remove fields from UA mappings which don't need to be searchable #64547

Closed

Merge branch 'master' into np/es-ui-cleanup

0f7ce01

jloleysens approved these changes Apr 28, 2020

View reviewed changes

cjcenizal added 2 commits April 28, 2020 05:36

Merge branch 'master' into np/es-ui-cleanup

2ed99c6

Fix mistake in merge conflict resolution in which legacy siem is impo…

3115da0

…rted.

cjcenizal merged commit 3b753ec into elastic:master Apr 28, 2020

cjcenizal deleted the np/es-ui-cleanup branch April 28, 2020 16:41

cjcenizal mentioned this pull request Apr 28, 2020

[7.x] ES UI new platform cleanup (#64332) #64706

Merged

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Apr 28, 2020

ES UI new platform cleanup (elastic#64332)

489e184

cjcenizal added a commit that referenced this pull request Apr 29, 2020

[7.x] ES UI new platform cleanup (#64332) (#64706)

61822d8

cjcenizal mentioned this pull request Jul 14, 2020

Immense Upgrade Assistant error messages are indexed, preventing Kibana from starting #71642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ES UI new platform cleanup #64332

ES UI new platform cleanup #64332

cjcenizal commented Apr 23, 2020 •

edited

Loading

elasticmachine commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cchaos commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cchaos left a comment

joshdover left a comment

cjcenizal commented Apr 23, 2020

cjcenizal Apr 24, 2020

pgayvallet Apr 27, 2020 •

edited

Loading

cjcenizal Apr 27, 2020

pgayvallet Apr 27, 2020 •

edited

Loading

cjcenizal commented Apr 27, 2020

jloleysens left a comment

kibanamachine commented Apr 28, 2020

	// we don't want to allow `true` in the public `SavedObjectsTypeMappingDefinition` type, however
	// this is needed for the config that is kinda a special type. To avoid adding additional internal types
	// just for this, we hardcast to any here.
	dynamic: true as any,

ES UI new platform cleanup #64332

ES UI new platform cleanup #64332

Conversation

cjcenizal commented Apr 23, 2020 • edited Loading

elasticmachine commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cchaos commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cjcenizal commented Apr 23, 2020

cchaos left a comment

Choose a reason for hiding this comment

joshdover left a comment

Choose a reason for hiding this comment

cjcenizal commented Apr 23, 2020

cjcenizal Apr 24, 2020

Choose a reason for hiding this comment

pgayvallet Apr 27, 2020 • edited Loading

Choose a reason for hiding this comment

cjcenizal Apr 27, 2020

Choose a reason for hiding this comment

pgayvallet Apr 27, 2020 • edited Loading

Choose a reason for hiding this comment

cjcenizal commented Apr 27, 2020

jloleysens left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 28, 2020

💚 Build Succeeded

History

cjcenizal commented Apr 23, 2020 •

edited

Loading

pgayvallet Apr 27, 2020 •

edited

Loading

pgayvallet Apr 27, 2020 •

edited

Loading