[Lens] Don't use auto interval to get interval for single bar

[mbondyra]

Summary

This is a proposal of solution of the following problem:
Charts are not able to calculate an interval for a chart with a single bar to display proper width of it. Right now we're passing minInterval from aggsConfig interval param, but it'll be removed with the PR: #63874

What I am proposing is to calculate the approximate interval with a simplified method of what we do for auto interval and as it's an edgecase, I don't think we need a big precision.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

I just tested a little and this fix doesn't work anymore when the user is selecting a custom interval.

For example, if the custom interval is larger than the configured time range, no bar is shown as well:

Vislib vis types can deal with the situation

I guess this happens because in this case the bucket starts before the min value of the x domain, and because the minInterval calculation doesn't come close to the actual value (because it's simulating the auto behavior) it renders the bar off-screen to the left.

I suggest we solve this now by doing a hybrid of the old behavior and the approach in this PR - if the meta object contains an actual interval, use it. Otherwise fall back to the logic with guessing the interval. I'm getting more and more convinced that in the long-term the data table should contain this information.

[mbondyra]

@flash1293 Thank you for cautiousness! I tested it on 7.6.1 and looks like we have the bug there too 😭 Nevertheless, I agree, this probably makes things even worse so I'll add a correction. I submitted an issue: #64544

[flash1293]

In this case I’m going to approve, we can solve the other bug separately. Maybe it even requires an elastic-charts fix, let’s see.

[wylieconlon]

I agree with @flash1293 about this entire comment:

• if the meta object contains an actual interval, use it. Otherwise fall back to the logic with guessing the interval. I'm getting more and more convinced that in the long-term the data table should contain this information.

I also agree @mbondyra that the bug with intervals larger than the time range should be dealt with separately.

[mbondyra]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 342deb5

History

• 💔 Build #43637 failed 954cf4c
• 💚 Build #43349 succeeded bb8cd9a
• 💛 Build #43319 was flaky 93b128947a62201ff18c3cf124acc40c35181502

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream