Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce visTypeMarkdown bundle size #64638

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Reduce visTypeMarkdown bundle size #64638

merged 2 commits into from
Apr 30, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 28, 2020 •
edited
Loading

Summary

Summary

Part of :

loads some components lazily:
Reduces the plugin bundle size from 2.3Mb to 2Mb.

For maintainers

@mshustov mshustov added chore performance Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov marked this pull request as ready for review April 28, 2020 14:05
@mshustov mshustov requested review from a team and flash1293 April 28, 2020 14:05
@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov changed the title load SettingsOptions component lazily reduce vis_type_markdown js bundle size Apr 29, 2020
flash1293
flash1293 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works fine

@mshustov mshustov merged commit 693a84a into elastic:master Apr 30, 2020
@mshustov mshustov deleted the slim-vis_type_markdown branch April 30, 2020 17:16
@mshustov mshustov mentioned this pull request Apr 30, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 30, 2020
@mshustov @elasticmachine
load SettingsOptions component lazily (elastic#64638)
cf96bc4 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mshustov added a commit that referenced this pull request Apr 30, 2020
@mshustov @elasticmachine
load SettingsOptions component lazily (#64638) (#64930)
fcb55bc 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@pgayvallet pgayvallet mentioned this pull request May 11, 2020
Closed
17 tasks
@tylersmalley tylersmalley mentioned this pull request Mar 30, 2021
Closed
@lizozom lizozom changed the title reduce vis_type_markdown js bundle size Reduce visTypeMarkdown bundle size Apr 18, 2022
@lizozom lizozom mentioned this pull request Apr 18, 2022
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backported chore performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @flash1293