Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes bug in ML signals promotion #64711

Merged
merged 2 commits into from
Apr 29, 2020
Merged

[SIEM] Fixes bug in ML signals promotion #64711

merged 2 commits into from
Apr 29, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Apr 28, 2020

Summary

This swaps lodash's set with set-value's equivalent in our signal promotion logic for ML rules.

For maintainers

@rylnd rylnd added the v7.7.0 label Apr 28, 2020
@rylnd rylnd self-assigned this Apr 28, 2020
spong
spong approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and tested locally, looks good to me! 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd marked this pull request as ready for review April 29, 2020 00:04
@rylnd rylnd added the release_note:skip Skip the PR/issue when compiling release notes label Apr 29, 2020
@rylnd rylnd mentioned this pull request Apr 29, 2020
Merged
1 task
@rylnd rylnd merged commit 0f45614 into elastic:7.7 Apr 29, 2020
@rylnd rylnd deleted the bugfix_ml_signals branch April 29, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@rylnd rylnd

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rylnd @kibanamachine @spong