Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] Component integration tests #65316

Merged
merged 16 commits into from
May 7, 2020
Merged

[Ingest pipelines] Component integration tests #65316

merged 16 commits into from
May 7, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented May 5, 2020 •
edited
Loading

This PR adds component integration tests for the Ingest Node Pipelines UI.

Screen Shot 2020-04-28 at 9 00 57 PM

Screen Shot 2020-04-28 at 9 01 49 PM

Screen Shot 2020-04-28 at 9 02 38 PM

Screen Shot 2020-04-28 at 9 03 10 PM

@alisonelizabeth alisonelizabeth added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth mentioned this pull request May 5, 2020
Closed
@alisonelizabeth alisonelizabeth marked this pull request as ready for review May 5, 2020 17:53
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner May 5, 2020 17:53
sebelga
sebelga approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @alisonelizabeth ! I left a few comments, no blockers. I ran the tests locally and no issues 👍

x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/http_requests.ts Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/http_requests.ts Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipeline_form.helpers.ts Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_list.helpers.ts Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx

await act(async () => {
testBed = await setup();
await testBed.waitFor('pipelineForm');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about waitFor. I realized it might not have been the best idea to add setTimout calls inside our tests (which is what waitFor does).
It seems (but I am still investigating) that some of the timing issues we are getting in our tests come from setTimeout calls inside the code being tested (and the form lib has some).
Once I get to the bottom of it I'll share my findings 😊 For now let's keep with this small hack.

x-pack/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_list.test.ts Outdated Show resolved Hide resolved
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

cuff-links
cuff-links approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out locally. Ran several times. LGTM. Coverage is good and takes care of our basic use cases.

@alisonelizabeth
Copy link
Contributor Author

Thanks for the review @cuff-links and @sebelga! Going to run this through CI a few times before merging.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 5629dd6 into elastic:master May 7, 2020
@alisonelizabeth alisonelizabeth deleted the ingest_pipelines/component_tests branch May 7, 2020 16:17
This was referenced May 7, 2020
Merged
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request May 7, 2020
@alisonelizabeth
[Ingest pipelines] Component integration tests (elastic#65316)
1448d5a
alisonelizabeth added a commit that referenced this pull request May 7, 2020
@alisonelizabeth
[7.8] [Ingest pipelines] Component integration tests (#65316) (#65724)
b32c068
alisonelizabeth added a commit that referenced this pull request May 7, 2020
@alisonelizabeth
[7.x] [Ingest pipelines] Component integration tests (#65316) (#65723)
e23e273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@cuff-links cuff-links cuff-links approved these changes

Assignees
No one assigned
Labels
chore Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @cuff-links @sebelga