[ML] Show warning when the model memory limit is higher than the memory available in the ML node #65652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
qn895
jgowdyelastic
added
:ml
bug
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
cc @droberts195 |
Member
|
LGTM |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
May 8, 2020
…ry available in the ML node (elastic#65652) * [ML] Show warning when the model memory limit is higher than the memory available in the ML node * reverting UI check * removing from UI job validator * adding cap to estimate mml * adding mml value to message * fixing translations * updating translations * fixing translation ids
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
May 8, 2020
…ry available in the ML node (elastic#65652) * [ML] Show warning when the model memory limit is higher than the memory available in the ML node * reverting UI check * removing from UI job validator * adding cap to estimate mml * adding mml value to message * fixing translations * updating translations * fixing translation ids
2 tasks
walterra
added a commit
to walterra/kibana
that referenced
this pull request
May 11, 2020
elastic#65967) Adapt jest test mocks to consider update introduced in elastic#65652. # Conflicts: # x-pack/plugins/ml/server/models/job_validation/job_validation.test.ts
jgowdyelastic
added a commit
that referenced
this pull request
May 11, 2020
…ry available in the ML node (#65652) (#65842) * [ML] Show warning when the model memory limit is higher than the memory available in the ML node * reverting UI check * removing from UI job validator * adding cap to estimate mml * adding mml value to message * fixing translations * updating translations * fixing translation ids Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
May 11, 2020
…ry available in the ML node (#65652) (#65841) * [ML] Show warning when the model memory limit is higher than the memory available in the ML node * reverting UI check * removing from UI job validator * adding cap to estimate mml * adding mml value to message * fixing translations * updating translations * fixing translation ids Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user inputted mml is greater than the effective max mml from the ML node, a warning is shown.
Also ensures the estimated mml is never greater than the effective max mml.
Fixes #63942
Relates to elastic/elasticsearch#55529
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately