Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix document title according to page #65665

Merged
merged 5 commits into from
May 12, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #65664

Displays correct Uptime title according to page.

@shahzad31 shahzad31 requested a review from a team as a code owner May 7, 2020 11:55
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this May 7, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0 labels May 7, 2020
@shahzad31 shahzad31 requested a review from andrewvc May 7, 2020 11:58
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this issue.

const overviewPage = useRouteMatch(OVERVIEW_ROUTE);
const monitorPage = useRouteMatch(MONITOR_ROUTE);

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really fragile. If we add a new page we have to remember to update this page. We probably won't.

Make we should make this a part of the page header, and use a prop passed in there instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i refactored it, use typescript now it will be enforced and hopefully next next page addition will be taken care of.


useEffect(() => {
if (overviewPage) {
document.title = 'Uptime - Kibana';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these all use the safe suffix Uptime - Kibana let's not repeat ourselves on each assignment.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 9 times on tracked branches: https://github.com/elastic/kibana/issues/65949

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook
[00:06:56]           └-: sample data dashboard
[00:06:56]             └-> "before all" hook
[00:06:56]             └-> "before all" hook
[00:06:56]               │ debg ... sleep(5000) start
[00:07:01]               │ debg ... sleep(5000) end
[00:07:01]               │ debg navigateToUrl http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:02]               │ debg browser[INFO] http://localhost:6181/app/kibana?_t=1589205171441#/home/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:02]               │
[00:07:02]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:02]               │ debg currentUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:02]               │          appUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:02]               │ debg TestSubjects.find(kibanaChrome)
[00:07:02]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:07:05]               │ debg isGlobalLoadingIndicatorVisible
[00:07:05]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:05]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:05]               │ debg browser[INFO] http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-11T13:52:54Z
[00:07:05]               │        Adding connection to http://localhost:6181/elasticsearch
[00:07:05]               │
[00:07:05]               │      "
[00:07:05]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:05]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:06]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:07:06]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:07:06]               │ debg TestSubjects.click(addSampleDataSetflights)
[00:07:06]               │ debg Find.clickByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:07:06]               │ debg Find.findByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:07:06]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:07:06]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:07:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] applying create index request using v1 templates []
[00:07:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [kibana_sample_data_flights] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:07:06]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] updating number_of_replicas to [0] for indices [kibana_sample_data_flights]
[00:07:11]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [.kibana_2/nRHOTGUcRSKtuWEket-5Fg] update_mapping [_doc]
[00:07:11]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [.kibana_2/nRHOTGUcRSKtuWEket-5Fg] update_mapping [_doc]
[00:07:11]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [.kibana_2/nRHOTGUcRSKtuWEket-5Fg] update_mapping [_doc]
[00:07:11]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [.kibana_2/nRHOTGUcRSKtuWEket-5Fg] update_mapping [_doc]
[00:07:12]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:07:12]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:07:15]               │ debg --- retry.tryForTime error: [data-test-subj="addSampleDataSetflights"] is not displayed
[00:07:15]               │ debg applying update to kibana config: {"timepicker:quickRanges":"[\n        {\n          \"from\": \"now-30d\",\n          \"to\": \"now+40d\",\n          \"display\": \"sample data range\"\n        },\n        {\n          \"from\": \"now/d\",\n          \"to\": \"now/d\",\n          \"display\": \"Today\"\n        },\n        {\n          \"from\": \"now/w\",\n          \"to\": \"now/w\",\n          \"display\": \"This week\"\n        },\n        {\n          \"from\": \"now-15m\",\n          \"to\": \"now\",\n          \"display\": \"Last 15 minutes\"\n        },\n        {\n          \"from\": \"now-30m\",\n          \"to\": \"now\",\n          \"display\": \"Last 30 minutes\"\n        },\n        {\n          \"from\": \"now-1h\",\n          \"to\": \"now\",\n          \"display\": \"Last 1 hour\"\n        },\n        {\n          \"from\": \"now-24h\",\n          \"to\": \"now\",\n          \"display\": \"Last 24 hours\"\n        },\n        {\n          \"from\": \"now-7d\",\n          \"to\": \"now\",\n          \"display\": \"Last 7 days\"\n        },\n        {\n          \"from\": \"now-30d\",\n          \"to\": \"now\",\n          \"display\": \"Last 30 days\"\n        },\n        {\n          \"from\": \"now-90d\",\n          \"to\": \"now\",\n          \"display\": \"Last 90 days\"\n        },\n        {\n          \"from\": \"now-1y\",\n          \"to\": \"now\",\n          \"display\": \"Last 1 year\"\n        }\n      ]"}
[00:07:15]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] [.kibana_2/nRHOTGUcRSKtuWEket-5Fg] update_mapping [_doc]
[00:07:16]               │ debg click "Discover" app link
[00:07:16]               │ debg TestSubjects.exists(collapsibleNav)
[00:07:16]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:07:19]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:07:19]               │ debg TestSubjects.click(toggleNavButton)
[00:07:19]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:19]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:20]               │ debg TestSubjects.find(collapsibleNav)
[00:07:20]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:07:20]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:07:20]               │ debg browser[INFO] http://localhost:6181/app/kibana#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:20]               │
[00:07:20]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:22]               │ debg browser[INFO] http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-11T13:53:11Z
[00:07:22]               │        Adding connection to http://localhost:6181/elasticsearch
[00:07:22]               │
[00:07:22]               │      "
[00:07:22]               │ debg TestSubjects.click(indexPattern-switch-link)
[00:07:22]               │ debg Find.clickByCssSelector('[data-test-subj="indexPattern-switch-link"]') with timeout=10000
[00:07:22]               │ debg Find.findByCssSelector('[data-test-subj="indexPattern-switch-link"]') with timeout=10000
[00:07:23]               │ debg Find.clickByCssSelector('[data-test-subj="indexPattern-switcher"] [title="kibana_sample_data_flights"]') with timeout=10000
[00:07:23]               │ debg Find.findByCssSelector('[data-test-subj="indexPattern-switcher"] [title="kibana_sample_data_flights"]') with timeout=10000
[00:07:24]               │ debg isGlobalLoadingIndicatorVisible
[00:07:24]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:24]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:24]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:24]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:07:24]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:24]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:24]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_sample_data range)
[00:07:24]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:24]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:24]               │ debg isGlobalLoadingIndicatorVisible
[00:07:24]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:24]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:24]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:25]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:07:25]               │ debg TestSubjects.find(discoverQueryHits)
[00:07:25]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:07:25]             └-> should launch sample flights data set dashboard
[00:07:25]               └-> "before each" hook: global before each
[00:07:25]               │ debg click "Dashboard" app link
[00:07:25]               │ debg TestSubjects.exists(collapsibleNav)
[00:07:25]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:07:28]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:07:28]               │ debg TestSubjects.click(toggleNavButton)
[00:07:28]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:28]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:29]               │ debg TestSubjects.find(collapsibleNav)
[00:07:29]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:07:29]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:07:32]               │ debg Load Saved Dashboard [Flights] Global Flight Dashboard
[00:07:32]               │ debg gotoDashboardLandingPage
[00:07:32]               │ debg onDashboardLandingPage
[00:07:32]               │ debg TestSubjects.exists(dashboardLandingPage)
[00:07:32]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:07:32]               │ debg searchForItemWithName: [Flights] Global Flight Dashboard
[00:07:32]               │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:07:32]               │ debg isGlobalLoadingIndicatorVisible
[00:07:32]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:32]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:33]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:07:35]               │ debg --- retry.tryForTime failed again with the same message...
[00:07:35]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:35]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:35]               │ debg TestSubjects.click(dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard)
[00:07:35]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard"]') with timeout=10000
[00:07:35]               │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard"]') with timeout=10000
[00:07:35]               │ debg isGlobalLoadingIndicatorVisible
[00:07:35]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:35]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:35]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:35]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:35]               │ debg TestSubjects.missingOrFail(dashboardLandingPage)
[00:07:35]               │ debg Find.waitForDeletedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=10000
[00:07:36]               │ debg browser[WARNING] http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 20:69562 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
[00:07:36]               │      Arguments: 
[00:07:36]               │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: now-24h, _f: undefined, _strict: undefined, _locale: [object Object]
[00:07:36]               │      Error
[00:07:36]               │          at Function.createFromInputFallback (http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:69970)
[00:07:36]               │          at http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:89720
[00:07:36]               │          at http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:89771
[00:07:36]               │          at Mt (http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90065)
[00:07:36]               │          at Ct (http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90442)
[00:07:36]               │          at St (http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90524)
[00:07:36]               │          at r (http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:66808)
[00:07:36]               │          at Function.convertTimeToUTCString (http://localhost:6181/33067/bundles/plugin/dashboard/dashboard.plugin.js:27:22213)
[00:07:36]               │          at Function.areTimesEqual (http://localhost:6181/33067/bundles/plugin/dashboard/dashboard.plugin.js:27:22401)
[00:07:36]               │          at DashboardStateManager.getTimeChanged (http://localhost:6181/33067/bundles/plugin/dashboard/dashboard.plugin.js:82:103161)"
[00:07:36]               │ debg isGlobalLoadingIndicatorVisible
[00:07:36]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:36]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:36]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:36]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:41]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:07:41]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:41]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:42]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_sample_data range)
[00:07:42]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:42]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:45]               │ debg isGlobalLoadingIndicatorVisible
[00:07:45]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:45]               │ debg browser[INFO] http://localhost:6181/33067/bundles/plugin/visTypeVega/0.plugin.js 0:13090 "%cWelcome to Kibana Vega Plugin!" "font-size: 16px; font-weight: bold;"
[00:07:45]               │ debg browser[INFO] http://localhost:6181/33067/bundles/plugin/visTypeVega/0.plugin.js 0:13176 "You can access the Vega view with VEGA_DEBUG. Learn more at https://vega.github.io/vega/docs/api/debugging/."
[00:07:49]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:49]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:49]               │ debg Renderable.waitForRender for 1 elements
[00:07:49]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:07:49]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:07:49]               │ debg --- retry.try error: 1 elements still loading contents
[00:07:50]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:07:50]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:07:51]               │ debg Checking pie charts rendered
[00:07:51]               │ debg PieChart.expectPieSliceCount(4)
[00:07:51]               │ debg PieChart.getPieSliceCount
[00:07:51]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:07:51]               │ debg click "Discover" app link
[00:07:51]               │ debg TestSubjects.exists(collapsibleNav)
[00:07:51]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:07:53]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:07:54]               │ debg TestSubjects.click(toggleNavButton)
[00:07:54]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:54]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:54]               │ debg TestSubjects.find(collapsibleNav)
[00:07:54]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:07:57]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:00]               │ debg isGlobalLoadingIndicatorVisible
[00:08:00]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:00]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:01]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:02]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:02]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:02]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:02]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:02]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:02]               │ debg click "Dashboard" app link
[00:08:02]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:02]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:04]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:05]               │ debg TestSubjects.click(toggleNavButton)
[00:08:05]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:05]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:05]               │ debg TestSubjects.find(collapsibleNav)
[00:08:05]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:06]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:06]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:08:06]               │ debg isGlobalLoadingIndicatorVisible
[00:08:06]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:06]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:06]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:07]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:07]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:11]               │ debg Renderable.waitForRender for 1 elements
[00:08:11]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:11]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:13]               │ debg Checking pie charts rendered
[00:08:13]               │ debg PieChart.expectPieSliceCount(4)
[00:08:13]               │ debg PieChart.getPieSliceCount
[00:08:13]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:13]               └- ✓ pass  (47.5s) "dashboard sample data dashboard should launch sample flights data set dashboard"
[00:08:13]             └-> toggle from Discover to Dashboard attempt 1
[00:08:13]               └-> "before each" hook: global before each
[00:08:13]               │ debg click "Discover" app link
[00:08:13]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:13]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:15]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:16]               │ debg TestSubjects.click(toggleNavButton)
[00:08:16]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:16]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:16]               │ debg TestSubjects.find(collapsibleNav)
[00:08:16]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:19]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:22]               │ debg isGlobalLoadingIndicatorVisible
[00:08:22]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:23]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:24]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:24]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:24]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:24]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:24]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:24]               │ debg click "Dashboard" app link
[00:08:24]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:26]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:27]               │ debg TestSubjects.click(toggleNavButton)
[00:08:27]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:27]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:27]               │ debg TestSubjects.find(collapsibleNav)
[00:08:27]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:28]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:28]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:08:28]               │ debg isGlobalLoadingIndicatorVisible
[00:08:28]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:28]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:28]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:28]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:33]               │ debg Renderable.waitForRender for 1 elements
[00:08:33]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:33]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:33]               │ debg --- retry.try error: 1 elements still loading contents
[00:08:34]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:34]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:35]               │ debg Checking pie charts rendered
[00:08:35]               │ debg PieChart.expectPieSliceCount(4)
[00:08:35]               │ debg PieChart.getPieSliceCount
[00:08:35]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:35]               └- ✓ pass  (22.2s) "dashboard sample data dashboard toggle from Discover to Dashboard attempt 1"
[00:08:35]             └-> toggle from Discover to Dashboard attempt 2
[00:08:35]               └-> "before each" hook: global before each
[00:08:35]               │ debg click "Discover" app link
[00:08:35]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:35]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:38]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:38]               │ debg TestSubjects.click(toggleNavButton)
[00:08:38]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:38]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:39]               │ debg TestSubjects.find(collapsibleNav)
[00:08:39]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:39]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:42]               │ debg isGlobalLoadingIndicatorVisible
[00:08:42]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:42]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:43]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:44]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:44]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:44]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:44]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:44]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:44]               │ debg click "Dashboard" app link
[00:08:44]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:44]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:47]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:47]               │ debg TestSubjects.click(toggleNavButton)
[00:08:47]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:47]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:47]               │ debg TestSubjects.find(collapsibleNav)
[00:08:47]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:48]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:08:48]               │ debg isGlobalLoadingIndicatorVisible
[00:08:48]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:48]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:48]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] to [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] to [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] in policy [kibana-event-log-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] in policy [kibana-event-log-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] in policy [kibana-event-log-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] in policy [kibana-event-log-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] in policy [kibana-event-log-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:08:50]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1589202490967177003] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [kibana-event-log-policy]
[00:08:53]               │ debg Renderable.waitForRender for 1 elements
[00:08:53]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:53]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:53]               │ debg --- retry.try error: 1 elements still loading contents
[00:08:54]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:54]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:55]               │ debg Checking pie charts rendered
[00:08:55]               │ debg PieChart.expectPieSliceCount(4)
[00:08:55]               │ debg PieChart.getPieSliceCount
[00:08:55]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:55]               │ debg Checking area, bar and heatmap charts rendered
[00:08:55]               │ debg DashboardExpect.seriesElementCount(15)
[00:08:55]               │ debg Find.allByCssSelector('.series') with timeout=2500
[00:08:55]               │ debg Checking saved searches rendered
[00:08:55]               │ debg DashboardExpect.savedSearchRowCount(50)
[00:08:55]               │ debg TestSubjects.findAll(docTableExpandToggleColumn)
[00:08:55]               │ debg Find.allByCssSelector('[data-test-subj="docTableExpandToggleColumn"]') with timeout=2500
[00:08:56]               │ debg Checking input controls rendered
[00:08:56]               │ debg DashboardExpect.inputControlItemCount(3)
[00:08:56]               │ debg TestSubjects.findAll(inputControlItem)
[00:08:56]               │ debg Find.allByCssSelector('[data-test-subj="inputControlItem"]') with timeout=10000
[00:08:56]               │ debg Checking tag cloud rendered
[00:08:56]               │ debg DashboardExpect.tagCloudWithValuesFound(Sunny,Rain,Clear,Cloudy,Hail)
[00:08:56]               │ debg TestSubjects.findAll(tagCloudVisualization)
[00:08:56]               │ debg Find.allByCssSelector('[data-test-subj="tagCloudVisualization"]') with timeout=10000
[00:08:56]               │ debg TestSubjects.descendantExists(Sunny)
[00:08:56]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Sunny"]') with timeout=2500
[00:08:56]               │ debg TestSubjects.descendantExists(Rain)
[00:08:56]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Rain"]') with timeout=2500
[00:08:56]               │ debg TestSubjects.descendantExists(Clear)
[00:08:56]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Clear"]') with timeout=2500
[00:08:56]               │ debg TestSubjects.descendantExists(Cloudy)
[00:08:56]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Cloudy"]') with timeout=2500
[00:08:56]               │ debg TestSubjects.descendantExists(Hail)
[00:08:56]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Hail"]') with timeout=2500
[00:08:56]               │ debg Checking vega chart rendered
[00:08:56]               │ debg Find.existsByCssSelector('.vgaVis__view') with timeout=2500
[00:08:56]               └- ✓ pass  (20.9s) "dashboard sample data dashboard toggle from Discover to Dashboard attempt 2"
[00:08:56]             └-> "after all" hook
[00:08:56]               │ debg navigateToUrl http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:08:56]               │ debg browser[INFO] http://localhost:6181/app/kibana?_t=1589205285949#/home/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:08:56]               │
[00:08:56]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:08:56]               │ debg currentUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:08:56]               │          appUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:08:56]               │ debg TestSubjects.find(kibanaChrome)
[00:08:56]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:00]               │ debg TestSubjects.click(removeSampleDataSetflights)
[00:09:00]               │ debg Find.clickByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:09:00]               │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:09:00]               │ debg browser[INFO] http://localhost:6181/33067/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-11T13:54:49Z
[00:09:00]               │        Adding connection to http://localhost:6181/elasticsearch
[00:09:00]               │
[00:09:00]               │      "
[00:09:01]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:09:01]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:09:02]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:02]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:05]               │ debg --- retry.tryForTime error: [data-test-subj="addSampleDataSetflights"] is not displayed
[00:09:05]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard sample data dashboard _after all_ hook.png"
[00:09:05]               │ info Current URL is: http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:09:06]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard sample data dashboard _after all_ hook.html
[00:09:06]               └- ✖ fail: "dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2""
[00:09:06]               │

Stack Trace

Error: expected true to equal false
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.after (test/functional/apps/dashboard/_async_dashboard.ts:109:30)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from andrewvc May 11, 2020 15:45
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);
const baseTitle = 'Uptime - Kibana';

const Routes: RouteProps[] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ on the move to plain objects here, easier to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Fix app title in document title
4 participants