[Lens] fix redirect after reload #66328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the url when the app starts and tracked as part of the state
ThomThomson
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
ThomThomson
added
Feature:Dashboard
flash1293
reviewed
May 13, 2020
| const originatingApp = urlParams.embeddableOriginatingApp; | ||
| const originatingAppFromUrl = urlParams.embeddableOriginatingApp; | ||
| if (urlParams.embeddableOriginatingApp) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Why do we need to get async here?
There was a problem hiding this comment.
This used to be needed due to the url change and the render method creating an infinite loop. This is no longer necessary, so it's been removed!
2 tasks
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
May 14, 2020
There was a problem hiding this comment.
Tested in firefox and works fine, after a reload Lens doesn't attempt to redirect back to the dashboard - without redirect it still works fine. Discussed the approach offline and it is a good approach as a temporary workaround (will ultimately replaced by using state of the history). LGTM
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
May 14, 2020
Changed the way the lens app tracks originatingApp. It is now removed from the url when the app starts and is tracked as part of the state
ThomThomson
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 'originatingApp' param persisting after a refresh in 7.8 caused a serious issue when redirecting back to dashboard.
Fixes #66304
Note
This is a temporary fix. Soon all of the navigation behavior via query params between dashboard, lens, and visualize will be removed and replaced with
application.navigateTo(appId, state)in a follow up PR for 7.x after #63443Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers