Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Disable map layout animation #66763

Merged
merged 3 commits into from
May 15, 2020
Merged

[APM] Disable map layout animation #66763

merged 3 commits into from
May 15, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented May 15, 2020

Don't animate the layout. Keep animation for centering/zoom.

preventDefault when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes #66695

Don't animate the layout. Keep animation for centering/zoom.

`preventDefault` when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes elastic#66695
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 15, 2020
@smith smith requested a review from a team as a code owner May 15, 2020 15:59
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 7f7585d into elastic:master May 15, 2020
smith added a commit to smith/kibana that referenced this pull request May 15, 2020
* [APM] Disable map layout animation

Don't animate the layout. Keep animation for centering/zoom.

`preventDefault` when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes elastic#66695
smith added a commit to smith/kibana that referenced this pull request May 15, 2020
* [APM] Disable map layout animation

Don't animate the layout. Keep animation for centering/zoom.

`preventDefault` when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes elastic#66695
smith added a commit that referenced this pull request May 15, 2020
* [APM] Disable map layout animation

Don't animate the layout. Keep animation for centering/zoom.

`preventDefault` when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes #66695
smith added a commit that referenced this pull request May 15, 2020
* [APM] Disable map layout animation

Don't animate the layout. Keep animation for centering/zoom.

`preventDefault` when centering an already focused node so it doesn't do an unnecessary navigation.

Fixes #66695
jloleysens added a commit that referenced this pull request May 18, 2020
…ine-editor

* 'master' of github.com:elastic/kibana: (157 commits)
  [ML] fix url assertion (#66850)
  Skip failing lens test(s). #66779
  [SOM] Preserve saved object references when saving the object (#66584)
  Use ES API from start contract (#66157)
  Reorganize Management apps into Ingest, Data, Alerts and Insights, Security, Kibana, and Stack groups (#65796)
  [Uptime] Fix flaky navigation to certs page in tests (#66806)
  [Maps] Do not check count for blended layers when layer is not visible (#66460)
  [SIEM] Fixes glob patterns from directory changes recently for GraphQL
  chore(NA): bump static-fs to 1.0.2 (#66775)
  [Maps] Handle cross cluster index _settings resp (#66797)
  [SIEM][Lists] Adds 90% of the REST API and client API for exception lists and exception items
  allow any type for customResponseHeaders config (#66689)
  [APM] Disable map layout animation (#66763)
  [ML] Add linking to dataframe from job management tab (#65778)
  [Maps] Get number of categories from palette (#66454)
  move oss features registration to KP (#66524)
  [kbn/plugin-helpers] typescript-ify (#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (#66746)
  FTR: move basic services under common folder (#66563)
  Migrate Beats Management UI to KP (#65791)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 18, 2020
* master:
  [ML] fix url assertion (elastic#66850)
  Skip failing lens test(s). elastic#66779
  [SOM] Preserve saved object references when saving the object (elastic#66584)
  Use ES API from start contract (elastic#66157)
  Reorganize Management apps into Ingest, Data, Alerts and Insights, Security, Kibana, and Stack groups (elastic#65796)
  [Uptime] Fix flaky navigation to certs page in tests (elastic#66806)
  [Maps] Do not check count for blended layers when layer is not visible (elastic#66460)
  [SIEM] Fixes glob patterns from directory changes recently for GraphQL
  chore(NA): bump static-fs to 1.0.2 (elastic#66775)
  [Maps] Handle cross cluster index _settings resp (elastic#66797)
  [SIEM][Lists] Adds 90% of the REST API and client API for exception lists and exception items
  allow any type for customResponseHeaders config (elastic#66689)
  [APM] Disable map layout animation (elastic#66763)
  [ML] Add linking to dataframe from job management tab (elastic#65778)
@cauemarcondes cauemarcondes self-assigned this May 18, 2020
@cauemarcondes
Copy link
Contributor

tested:

  • Chome ✅
  • FF ✅
  • Safari ✅

@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.8.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Service maps jumps every time it's refreshed
5 participants