[New Platform Migration]: Management - Implement NP API #66781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
force-pushed
the
management-routing
branch
2 times, most recently
from
3400fd5
to
a322ef7
Compare
alexwizp
changed the title
alexwizp
force-pushed
the
management-routing
branch
2 times, most recently
from
7cb9bff
to
e756202
Compare
alexwizp
force-pushed
the
management-routing
branch
from
e756202
to
3740707
Compare
…management-routing
…management-routing
|
Pinging @elastic/apm-ui (Team:apm) |
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
…nt_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
…nt_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
walterra
requested changes
Jun 3, 2020
There was a problem hiding this comment.
Unfortunately I identified an issue with the stack management navigation for the Anomaly Detection section. I can reproduce the issue consistently and verified it works on master as expected.
Steps to reproduce:
- Navigate to Stack Management (works)
- Click on Machine Learning Jobs (works)
- Click on a job to view in Anomaly Explorer or Single Metric Viewer (works)
- Navigate back to Stack Management (works)
- Click on Machine Learning Jobs BLANK PAGE
- If you then click on another menu item, Kibana completely reloads and you end up on its overall start page again.
An error gets thrown when you end up on the blank page: Uncaught (in promise) undefined
Hope this helps pinning down the problem.
alexwizp
force-pushed
the
management-routing
branch
from
cebef81
to
155c65f
Compare
|
@walterra this commit fixed problem which you showed in ML. But I don’t really like how dependency passing is implemented in ML. Firstly, I don’t understand why a dependency caching mechanism is needed, and why we are clean that cache on app destroy (actually it was a reason of issue which you showed). It seems to me that this should be implemented in one place (plugin.ts) using setup / start / stop hooks. |
|
@walterra honestly I think the following code can be also removed from |
walterra
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
@alexwizp LGTM, thanks for fixing it I can confirm it works with your commit! You're right about the dependency cache, it's a temporary workaround we used to be able to cut over to NP in time, we'll hopefully be able to remove it soonish.
legrego
approved these changes
Jun 3, 2020
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 3, 2020
* [New Platform Migration]: Management - Implement NP API Part of elastic#47432 * partial progress on a number of management sections * fix passing history * Fixed types * Fixed routing for Ingest Node Pipelines * introduce and use react router wrapped eui components * react router utils * work in progress => hashRouter to router * more partial progress * remove console.log * use reactRouterNavigate for management_sidebar * Breadcrumbs will need to make use of the reactRouterNavigate function * [triggersActions] app. Hash Router -> Router * Replace /app/kibana#/management urls to /app/management * remove ui/public/management * fix some links to management apps * fix management url for functional tests * add data-test-subj for EuiSideNavItem * partial progress * fix some of ts issues * Fixed breadcrumbs for data index management * [kibana/spaces] section * fix functional test * [role_management] fix Breadcrumbs * [api_keys] fix Breadcrumbs and Navigation * Fixed routing for remote cluster * [role_mapping] Partial progress * [users] partial progress * [watcher] partial progress * fix eslint issues * [snapshot_restore] partial progress * [rollup_jobs] partial progress * Fixed routing for cross cluster replications (partial progress). Enhanced reactRouterNavigate * Perf optimization: fix extra re-rendering * fix TS errors * x-pack fix config for functional tests * Fixed routing for index lifecycle management * fix some broken CI tests * fix PR comment * [snapshot_restore] move onClick into reactRouterNavigate * fix some jest * fix some functional tests * fix functiona test: management scripted fields testing regression for issue * fix some functional tests * [licence_management] partial progress * Fixed x-pack jest tests * [saved_object_management] partial progress * Fixed some tests * fix functional test: should add new role myroleEast * Reverted part of changes for ml * [transforms] partial progress * fix TS errors * fix functional: redirects to Kibana home * add support of Backward compatibility * fix functional: Saved objects management feature controls saved objects management global visualize all privileges listing redirects to Kibana home * fix PR comment * fix TS issues * Fixed x-pack jest tests * fix oss JEST * Fixed functional test * fix functional test * fix PR comment * Fixed i18n * fix typo * fix Styles * Fixed paths for cross_cluster_replication * fix wrong link * Fixed jest * Fixed some comments * fix sorting * fix type check * fixed x-pack jest * fixed x-pack jest * reverted using of parentHistory * Add debugging toasts to CCR. * Comment out non-CCR functional tests. * Fix typo. * Uncomment non-CCR functional tests. * Enable CCR. * fix CI * Add comment to explain why CCR is enabled by default and move config variable back to original location in CCR plugin. * revert some changes in APM * add space between index pattern name and tags * fix function test * Update x-pack/plugins/security/public/management/management_urls.ts Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/security/public/management/api_keys/api_keys_management_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/security/public/management/roles/roles_management_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/security/public/management/users/users_management_app.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/security/public/management/management_urls.ts Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Update x-pack/plugins/security/public/management/management_urls.ts Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * [security] getUrlForApp -> navigateToApp * [mp] fix Uncaught (in promise) undefined Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
|
@alexwizp This PR has the release_note:breaking label and therefore should be included in the Breaking Changes doc. Please add a description of the change to this PR that I can use in the doc. For an example, take a look at the 7.8 Breaking Changes doc. |
alexwizp
added
release_note:plugin_api_changes
|
@gchaps, we decided to replace
|
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard OutStack Traceand 5 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #47432
Dev Docs
Once #47431 is complete and reliance on old platform APIs has been removed we can implement the management NP interface and chrome - #43631
Todo List
Data
Alerts and Insights
Secuity
Kibana
Stack
For maintainers
[mattk] I've set up routing in all the management sections below although it isn't working in some and needs troubleshooting. Keep the console open as you may see errors.
I created src/plugins/kibana_react/public/react_router_navigate/react_router_navigate.tsx to help with navigation, particularly reactRouterNavigate. Usage: <EuiLink {...reactRouterNavigate(history, '/create')} {...otherEuiLinkParams}> - it sets both onClick and href so you can navigate without a page load and yet it acts like a normal link.