[Maps] Fix legend icon color for custom categorial palettes #67141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
May 20, 2020
| if (dynamicOptions.type === COLOR_MAP_TYPE.CATEGORICAL) { | ||
| if (dynamicOptions.useCustomColorPalette) { | ||
| return dynamicOptions.customColorPalette && dynamicOptions.customColorPalette.length | ||
| ? dynamicOptions.customColorPalette[0].color |
There was a problem hiding this comment.
The git diffs are not very good, but this is the line that fixed the problem. Added typing so errors like this would be caught. Change file to TS flagged customColorPalette[0].colorCategory
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
approved these changes
May 26, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 26, 2020
…67141) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced May 26, 2020
nreese
added a commit
that referenced
this pull request
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67047
The problem exists in https://github.com/elastic/kibana/blob/master/x-pack/plugins/maps/public/classes/styles/vector/components/legend/extract_color_from_style_property.js#L28. The logic pulls the first color from the color ramp but is pulling
customColorPalette[0].colorCategoryinstead ofcustomColorPalette[0].color.