Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lens] fix flaky functional test #67175

Merged
merged 2 commits into from
May 27, 2020
Merged

[lens] fix flaky functional test #67175

merged 2 commits into from
May 27, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented May 21, 2020 •
edited
Loading

Summary

Fixes #66779
Reverts the unstable test introduced along with datatable filtering. As the whole functional suite was commented, I prefer firstly to merge the stable test suite.

I tried to reproduce the failure on cloud staging environment and locally, running test multiple times - with no success.

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0 Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed v7.8.0 labels May 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon
wylieconlon approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely fixes the flakiness, but I don't like that we haven't found the actual cause of the flakiness. Could it be that the .save() call is causing some kind of refresh that takes longer than the timeout? It seems like the rest of these tests involving saving are not affected.

I'm approving because this is an improvement over skipped tests, but if you choose to merge it then I'd appreciate a followup issue.

@mbondyra
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit b352f0b into elastic:master May 27, 2020
@mbondyra mbondyra mentioned this pull request May 27, 2020
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 29, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

8 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67175 or prevent reminders by adding the backport:skip label.

@mbondyra mbondyra mentioned this pull request Jun 10, 2020
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request Jun 10, 2020
@mbondyra @elasticmachine
fix: fix flaky test (elastic#67175)
e15e189 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 11, 2020
mbondyra added a commit that referenced this pull request Jun 11, 2020
@mbondyra
[7.x] fix: fix flaky test (#67175) (#68773)
c51b9cd
@wylieconlon wylieconlon mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

@brianseeders brianseeders Awaiting requested review from brianseeders

@flash1293 flash1293 Awaiting requested review from flash1293

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@mbondyra @elasticmachine @kibanamachine @wylieconlon