[yarn start] pass cache option to KP so it flows to ClusterManager #67204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
This was referenced May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 22, 2020
spalger
pushed a commit
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that I broke the cache used by
yarn startin #66837 by not passing thecacheoption from thecli/serve/servescript into the KP so that it could be passed to the ClusterManager... There are a lot of anys in there and it seemed like it was working because we were testing that--no-cacheinvalidated the cache, but turns out the cache was always being invalidated!