[Logs UI] [skip-ci] Demonstrate blockers for writing custom search strategies effectively #67533
Conversation
weltenwort
added
Feature:Logs UI
| // Custom search strategies | ||
| plugins.data.search.registerSearchStrategyContext( | ||
| this.initializerContext.opaqueId, | ||
| 'logSources', |
There was a problem hiding this comment.
The compiler rejects this unless the ISearchContext has been extended using declaration merging. But then it incorrectly leaks this key to other callers.
| // something using data.search.search and payload | ||
| const { firstTotal, firstLoaded, firstResults } = await somethingThatCallsAnotherSearchStrategy( | ||
| payload | ||
| ); | ||
|
|
||
| // something using data.search.search and the first results | ||
| const { | ||
| secondTotal, | ||
| secondLoaded, | ||
| secondResults, | ||
| } = await somethingThatCallsAnotherSearchStrategy(firstResults); | ||
|
|
||
| const total = mergeTotalsSomehow(firstTotal, secondTotal); | ||
| const loaded = mergeLoadedSomehow(firstLoaded, secondLoaded); |
There was a problem hiding this comment.
This is meant to symbolize a sequential composition of two calls to other search strategies. Ideally parallel composition would also be possible.
There was a problem hiding this comment.
Supporting streaming results in the general case will also be tricky.
There was a problem hiding this comment.
After some more thought providing combinators for the general case is probably not feasible. Maybe thoroughly documenting the runtime semantics and response shape would be sufficient to enable devs to create specific composed strategies.
💔 Build Failed
Failed CI StepsTo update your PR or re-run it, just comment with: |
weltenwort
changed the title
weltenwort
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
The |
Summary
This tries to demonstrate some aspects of the data plugin's search strategy API that keep me from writing solution-specific search strategies:
dataplugin is not available inside of a search strategy handler.These points are further illustrated by inline comments below.