Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix renaming of saved search not displayed in breadcrumb #67577

Merged
merged 4 commits into from
Jun 4, 2020
Merged

[Discover] Fix renaming of saved search not displayed in breadcrumb #67577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cf3338
Fix renaming of savedsearch not displayed in breadcrumb
kertal May 28, 2020
44d3353
Merge branch 'master' into kertal-pr-2020-05-28-discover-fix-rename-s…
elasticmachine May 28, 2020
b9f4cc2
Merge branch 'master' into kertal-pr-2020-05-28-discover-fix-rename-s…
elasticmachine Jun 2, 2020
cd18521
Merge branch 'master' into kertal-pr-2020-05-28-discover-fix-rename-s…
elasticmachine Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/plugins/discover/public/application/angular/discover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,13 @@ function discoverController(
// Update defaults so that "reload saved query" functions correctly
setAppState(getStateDefaults());
chrome.docTitle.change(savedSearch.lastSavedTitle);
chrome.setBreadcrumbs([
{
text: discoverBreadcrumbsTitle,
href: '#/',
},
{ text: savedSearch.title },
]);
}
}
});
Expand Down
10 changes: 10 additions & 0 deletions test/functional/apps/discover/_discover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ export default function ({ getService, getPageObjects }) {
});
});

it('renaming a saved query should modify name in breadcrumb', async function () {
const queryName2 = 'Modified Query # 1';
await PageObjects.discover.loadSavedSearch(queryName1);
await PageObjects.discover.saveSearch(queryName2);

await retry.try(async function () {
expect(await PageObjects.discover.getCurrentQueryName()).to.be(queryName2);
});
});

it('should show the correct hit count', async function () {
const expectedHitCount = '14,004';
await retry.try(async function () {
Expand Down