Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Manage timeline templates user flow #67837

Merged
merged 140 commits into from
Jul 9, 2020
Merged

[Security Solution] Manage timeline templates user flow #67837

merged 140 commits into from
Jul 9, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented May 31, 2020 •
edited
Loading

Summary

Templates tab:
image

Create template flyout:
image

Add field to the template:
image

Regular field in template view:
image

Template field:
image

Covert between field types in template:
image

Added ability to create a new timeline from a specific template

image

Improvements:

  • Added progress bar at the top of the timeline flyout
  • Showing alerts on empty state

Checklist

Delete any items that are not applicable to this PR.

For maintainers

angorayc and others added 30 commits May 13, 2020 19:51
@angorayc
add template btn
6031d22
@angorayc
rename file
c38e8ac
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
d9dc0b7
@angorayc
unit test
b5df002
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
22c875c
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
37ee874
@angorayc
replace connector with useDispatch
9d8bae5
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
6c806a0
@angorayc
comments
d8ce05b
@angorayc
add disableTemplate
f41170f
@angorayc
rename flag
42aabde
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
7244827
@angorayc
fix types
6d36589
@angorayc
remove snapshot
38686d7
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
20075bc
@angorayc
fix types
a28f04f
@patrykkopycinski
WIP
957b4fb
@elasticmachine
Merge branch 'master' into template-btn
2a70bb6
@angorayc
add fix action
7e49075
@angorayc
move disableTemplate flag into constants
dc4c13e
@angorayc
fix types
93e2138
@patrykkopycinski
WIP
d4f2190
@patrykkopycinski
Fix timelineType
5d29f12
@angorayc
button style
b1c436c
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/create-t…
849c110 
…imeline-template-flow

# Conflicts:
#	x-pack/plugins/siem/public/timelines/components/timeline/properties/helpers.tsx
@angorayc
unit test
5f023a8
@angorayc
unit test
caa31e0
@angorayc
Merge remote-tracking branch 'upstream/master' into template-btn
73789cf
@patrykkopycinski
WIP
16f26fb
@angorayc
fix types
b86578a
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@XavierM
Copy link
Contributor

XavierM commented Jul 9, 2020

when I tried to create a rule and pick my template timeline, I cannot. I do not think we set up the right parameters for the query. It should be only timelineType: template

image

XavierM
XavierM approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this feature, it was not an easy one. You show a lot of patience and dexterity. But mostly, it is working as expected. 💪 🎸 💪 🎸 🏄

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 814 +2 812

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 1ed98d5 into elastic:master Jul 9, 2020
@patrykkopycinski patrykkopycinski deleted the feat/create-timeline-template-flow branch July 9, 2020 17:08
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 9, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 9, 2020
@patrykkopycinski
[Security Solution] Manage timeline templates user flow (elastic#67837)
2e89d7b
patrykkopycinski added a commit that referenced this pull request Jul 9, 2020
@patrykkopycinski
[Security Solution] Manage timeline templates user flow (#67837) (#71277
fe7b95c 
)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patrykkopycinski @angorayc @elasticmachine @XavierM @kibanamachine @MindyRS