Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana 7.7.0: Chart split orientation is wrong #67840

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Kibana 7.7.0: Chart split orientation is wrong #67840

merged 2 commits into from
Jun 3, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 1, 2020

Closes #67444

Summary

Kibana 7.7.0: Chart split orientation is wrong. New saved object migration script was added

Regression of #58462

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp added bug Fixes for quality problems that affect the customer experience regression release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues v8.0.0 v7.8.1 v7.7.2 labels Jun 1, 2020
@alexwizp alexwizp requested a review from a team as a code owner June 1, 2020 09:00
@alexwizp alexwizp self-assigned this Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by exporting a chart from 7.6.2 and importing - property gets migrated correctly. LGTM

@alexwizp
Copy link
Contributor Author

alexwizp commented Jun 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lukeelmers
lukeelmers approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code here LGTM, thanks for addressing this @alexwizp

@alexwizp alexwizp merged commit d7b830a into elastic:master Jun 3, 2020
@alexwizp alexwizp mentioned this pull request Jun 3, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 3, 2020
@alexwizp @elasticmachine
Kibana 7.7.0: Chart split orientation is wrong (elastic#67840)
473a57c 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Jun 3, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 3, 2020
@alexwizp @elasticmachine
Kibana 7.7.0: Chart split orientation is wrong (elastic#67840)
a47c41a 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Jun 3, 2020
Merged
alexwizp added a commit that referenced this pull request Jun 3, 2020
@alexwizp @elasticmachine
Kibana 7.7.0: Chart split orientation is wrong (#67840) (#68098)
6e54cf4 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Jun 3, 2020
@alexwizp @elasticmachine
Kibana 7.7.0: Chart split orientation is wrong (#67840) (#68099)
e6d16b1 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 4, 2020
@alexwizp
Kibana 7.7.0: Chart split orientation is wrong (elastic#67840)
aa5469b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
alexwizp added a commit that referenced this pull request Jun 4, 2020
@alexwizp
Kibana 7.7.0: Chart split orientation is wrong (#67840) (#68101)
2139661 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@flash1293 flash1293 flash1293 approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vis Editor Visualization editor issues regression release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.2 v7.8.1 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibana 7.7.0: Chart split orientation is wrong
5 participants
@alexwizp @elasticmachine @kibanamachine @flash1293 @lukeelmers