[Lens] Keep global filters, time range and refresh interval on refresh

[flash1293]

Fixes #61758

This PR uses the same approach as Visualize/Discover/Dashboard to keep the global query context (time range, refresh interval and pinned filters) around even if the page is refreshed or opened in another tab / browser.

As this behavior is difficult to validate via unit test, it adds a functional test suite which also makes sure the context is kept when navigating between apps.

• x-pack/plugins/lens/public/app_plugin/app.tsx contains the main changes.
• x-pack/plugins/lens/public/app_plugin/app.test.tsx was only changed to keep existing unit tests working, the behavior is not tested (because the only test I can think of is basically a reverse implementation of the actual code)
• x-pack/test/functional/apps/lens/persistent_context.ts contains the functional tests

Note: The original issue also states

Also a page reload in Lens should not lose the query and non-pinned filters

This is handled by #67689 - if query or non-pinned filters are changed, the user will be stopped from navigating away by modal. With this PR all changes the user did are either persisted in the URL or in the saved object and protected via modal.

Considerations

On this PR changing the time range will write a new history entry, so going back will bring you back to the last time range instead of navigating away from Lens. I'm not sure whether that's expected behavior, but it seems like an improvement over the current state, so I left it in. A thing we should add (if possible) is to prevent the user from losing configuration by using the back button, but it seems like this is out of scope for this PR. For reference: Maps is trapping the user and the back button doesn't work at all (not sure whether that's the right approach).

[wylieconlon]

Tested in Chrome and Safari and LGTM. Found an edge case which we may need to combine with index pattern persistence:

1. Create a pinned filter in a Dashboard
2. Go to Lens, and you might see that the pinned filter is showing a Warning text label
3. Change the Lens index pattern and the warning goes away

I don't expect you to fix this issue in this PR.

[wylieconlon]

I assume it's intentional that this range doesn't overlap with the default time range, but I'm not sure why? We do have a PageObjects.lens.goToTimeRange helper which wraps this.

[wylieconlon]

I think we need to add some of these dependencies to the useEffect list explicitly- the linting rule is not currently being required, but should be.

[mbondyra]

@elasticmachine merge upstream

[mbondyra]

@flash1293 could you modify the title and description of PR to include the fact that the refreshInterval is also included? Just for the clarity.

On this PR changing the time range will write a new history entry, so going back will bring you back to the last time range instead of navigating away from Lens.

The behaviour is consistent with the rest of visualize so it's a good start in my opinion.

Tested on FF, code LGTM.

@wylieconlon I checked the edge case you've written down here, but I don't get how it's buggy, it seems like a proper behaviour for me. Could you clarify what's the expected behaviour?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 870578b

History

• 💚 Build #51674 succeeded e6dbab7
• 💔 Build #51366 failed 0f300bc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[wylieconlon]

@mbondyra The text "Warning" is caused by a mismatch in the default index pattern vs the index pattern used in the filters. If we want to fix this, the best way is to look at the meta.indexpattern property of the filters and use that as our default.