-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index pattern public api => common #68289
Merged
mattkime
merged 33 commits into
elastic:master
from
mattkime:index_pattern_server_api_2
Jun 10, 2020
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
a2da8d3
partial progress
mattkime 3a40208
front end code should be working again
mattkime cb9e775
restore unknown field toast
mattkime 5de1b21
fix jest test mock
mattkime 2683b7a
Revert "fix jest test mock"
mattkime 2913835
fix jest test mock
mattkime 5cfaee5
add onError callback, remove comments
mattkime f963496
Merge branch 'master' into index_pattern_server_api_2
mattkime ec2f0c6
better define fieldFormats common start service
mattkime ebc56d8
dependency cleanup
mattkime c994a1f
Revert "dependency cleanup"
mattkime f097b31
update api docs
mattkime 6998499
remove commented lines
mattkime 01e6e2f
typefix
mattkime f75873f
refactor core usage
mattkime 49a06d7
Merge branch 'master' into index_pattern_server_api_2
elasticmachine ba4d131
Merge branch 'master' into index_pattern_server_api_2
mattkime 30bf1e0
more specific dependencies
mattkime 8e0f3b8
Merge branch 'master' into index_pattern_server_api_2
elasticmachine bce0d2e
Revert "more specific dependencies"
mattkime 90a8695
more specific core usage
mattkime 240371a
Merge branch 'index_pattern_server_api_2' of github.com:mattkime/kiba…
mattkime d8b1999
more specific core usage
mattkime 6c30c28
move field_mapping code from kibana_utils to data
mattkime f96d3c3
fix jest test mock
mattkime 5beadc0
Merge branch 'master' into index_pattern_server_api_2
elasticmachine 7aeb8f2
remove fields index file, was only re-exporting from common
mattkime ace29ae
Merge branch 'index_pattern_server_api_2' of github.com:mattkime/kiba…
mattkime e3a16b3
remove index pattern lib dir which just re-exports from common
mattkime 0b7f84f
remove re-export
mattkime 885c8ce
remove re-export
mattkime 03e849d
Revert "remove re-export"
mattkime 985e90a
Revert "remove re-export"
mattkime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
...opment/plugins/data/public/kibana-plugin-plugins-data-public.expandshorthand.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [expandShorthand](./kibana-plugin-plugins-data-public.expandshorthand.md) | ||
|
||
## expandShorthand variable | ||
|
||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
expandShorthand: (sh: Record<string, ShorthandFieldMapObject>) => Record<string, FieldMappingSpec> | ||
``` |
11 changes: 11 additions & 0 deletions
11
.../data/public/kibana-plugin-plugins-data-public.fieldmappingspec._deserialize.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [FieldMappingSpec](./kibana-plugin-plugins-data-public.fieldmappingspec.md) > [\_deserialize](./kibana-plugin-plugins-data-public.fieldmappingspec._deserialize.md) | ||
|
||
## FieldMappingSpec.\_deserialize property | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
_deserialize?: (mapping: string) => any | undefined; | ||
``` |
11 changes: 11 additions & 0 deletions
11
...ns/data/public/kibana-plugin-plugins-data-public.fieldmappingspec._serialize.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [FieldMappingSpec](./kibana-plugin-plugins-data-public.fieldmappingspec.md) > [\_serialize](./kibana-plugin-plugins-data-public.fieldmappingspec._serialize.md) | ||
|
||
## FieldMappingSpec.\_serialize property | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
_serialize?: (mapping: any) => string | undefined; | ||
``` |
21 changes: 21 additions & 0 deletions
21
...pment/plugins/data/public/kibana-plugin-plugins-data-public.fieldmappingspec.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [FieldMappingSpec](./kibana-plugin-plugins-data-public.fieldmappingspec.md) | ||
|
||
## FieldMappingSpec interface | ||
|
||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
export interface FieldMappingSpec | ||
``` | ||
|
||
## Properties | ||
|
||
| Property | Type | Description | | ||
| --- | --- | --- | | ||
| [\_deserialize](./kibana-plugin-plugins-data-public.fieldmappingspec._deserialize.md) | <code>(mapping: string) => any | undefined</code> | | | ||
| [\_serialize](./kibana-plugin-plugins-data-public.fieldmappingspec._serialize.md) | <code>(mapping: any) => string | undefined</code> | | | ||
| [type](./kibana-plugin-plugins-data-public.fieldmappingspec.type.md) | <code>ES_FIELD_TYPES</code> | | | ||
|
11 changes: 11 additions & 0 deletions
11
.../plugins/data/public/kibana-plugin-plugins-data-public.fieldmappingspec.type.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [FieldMappingSpec](./kibana-plugin-plugins-data-public.fieldmappingspec.md) > [type](./kibana-plugin-plugins-data-public.fieldmappingspec.type.md) | ||
|
||
## FieldMappingSpec.type property | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
type: ES_FIELD_TYPES; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,5 @@ | |
<b>Signature:</b> | ||
|
||
```typescript | ||
indexPattern?: IndexPattern; | ||
indexPattern?: IIndexPattern; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...elopment/plugins/data/public/kibana-plugin-plugins-data-public.mappingobject.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [MappingObject](./kibana-plugin-plugins-data-public.mappingobject.md) | ||
|
||
## MappingObject type | ||
|
||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
export declare type MappingObject = Record<string, FieldMappingSpec>; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we throw here and let the caller handle the exception. instead of passing
onNotification
in they can wrap code in try/cacheThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good idea but I'd prefer to address it in another ticket as this PR aims to be a minimal set of changes required to provide a common api. I think I'd need to examine all places where index patterns are used to ensure errors are being caught. I've added a ticket to #67920