[Reporting] Convert plugin setup and start to synchronous #68326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
changed the title
tsullivan
commented
Jun 4, 2020
x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
Outdated
Show resolved
Hide resolved
tsullivan
commented
Jun 4, 2020
|
|
||
| export interface BrowserDownload { | ||
| createDriverFactory: CreateDriverFactory; |
There was a problem hiding this comment.
Previously, the BrowserDownload interface wasn't being instantiated anywhere. Once I instantiated a variable as this interface, adding this createDriverFactory field was necessary.
tsullivan
commented
Jun 4, 2020
tsullivan
force-pushed
the
reporting/setup-nsyncified
branch
2 times, most recently
from
8657ab2
to
5f6c6a6
Compare
tsullivan
changed the title
tsullivan
force-pushed
the
reporting/setup-nsyncified
branch
4 times, most recently
from
294bc3a
to
af636ab
Compare
tsullivan
force-pushed
the
reporting/setup-nsyncified
branch
from
af636ab
to
9e654f1
Compare
Fix test mocks + add some plugin async helpers where needed
tsullivan
added
release_note:skip
tsullivan
commented
Jun 5, 2020
|
There is still a TODO for testing on this, but it is ready for review |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
spalger
approved these changes
Jun 9, 2020
Add plugin test for sync/error cases
joelgriffith
approved these changes
Jun 9, 2020
|
I'm happy with the changes here, let's let platform folks give final approval and then we should be good to merge |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
reviewed
Jun 11, 2020
| runValidations(config, elasticsearch, browserDriverFactory, this.logger); | ||
|
|
||
| this.logger.debug('Start complete'); | ||
| this.start$.next(true); |
There was a problem hiding this comment.
This is just for a unit test
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 11, 2020
) * [Reporting] Convert plugin setup and start to synchronous * revert class conversion * diff prettify * Fix test mocks + add some plugin async helpers where needed * no setupReady startReady needed * Add plugin test for sync/error cases * PR feedback on tests/setup logs * rename symbol Co-authored-by: Joel Griffith <joel.griffith@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Jun 11, 2020
…68932) * [Reporting] Convert plugin setup and start to synchronous * revert class conversion * diff prettify * Fix test mocks + add some plugin async helpers where needed * no setupReady startReady needed * Add plugin test for sync/error cases * PR feedback on tests/setup logs * rename symbol Co-authored-by: Joel Griffith <joel.griffith@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Joel Griffith <joel.griffith@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #68292
x-pack/plugins/reporting/server/browsers/create_browser_driver_factory.ts. The function had to be broken up. Afterwards, it's not useful as a wrapper helper function.Checklist
Delete any items that are not applicable to this PR.
For maintainers