EMT-401: add policy data to metadata and fix tests #68582

nnamdifrankie · 2020-06-08T22:24:03Z

Summary

Issue:
https://github.com/elastic/endpoint-app-team/issues/401

update HostMetadata type to include policy data.
update generator to generate new data.
update policy response type.
update tests to use generator, remove static sample data.
added api test to confirm that we can filter by policy status.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-06-09T15:28:07Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

nnamdifrankie · 2020-06-09T16:47:27Z

@elasticmachine merge upstream

charlie-pichette · 2020-06-09T17:56:40Z

@nnamdifrankie should this be tagged as v7.9.0 instead of v7.8.0?

nnamdifrankie · 2020-06-09T20:16:42Z

@elasticmachine merge upstream

nnamdifrankie · 2020-06-11T21:05:12Z

@elasticmachine merge upstream

…difrankie/kibana into EMT-401_add_policy_data_to_metadata

nnamdifrankie · 2020-06-12T02:49:18Z

@elasticmachine merge upstream

jonathan-buttner

I think we need to address the alert type mismatch with the schema.

jonathan-buttner · 2020-06-12T13:06:35Z

x-pack/plugins/security_solution/common/endpoint/generate_data.ts

@@ -271,7 +277,12 @@ export class EndpointDocGenerator {
 * Creates new random policy id for the host to simulate new policy application
 */
 public updatePolicyId() {
- this.commonInfo.endpoint.policy.id = this.randomChoice(POLICIES).id;
+ this.commonInfo.endpoint.policy.applied.id = this.randomChoice(POLICIES).id;


nit: Maybe change the name of this function since it's updating more than just the policy id right?

jonathan-buttner · 2020-06-12T13:09:53Z

x-pack/plugins/security_solution/common/endpoint/types.ts

@@ -253,7 +253,11 @@ export type AlertEvent = Immutable<{
 };
 endpoint: {
 policy: {
- id: string;
+ applied: {


hmm I don't think alerts will have this structure. The mapping for alerts looks like:

endpoint: fields: policy: fields: id: {} artifact: {}

based on here: https://github.com/elastic/endpoint-package/blob/master/custom_subsets/elastic_endpoint/events/malware_event.yaml#L26

Do we need to update the mapping?

elastic/endpoint-package#10

jonathan-buttner · 2020-06-12T13:12:23Z

x-pack/plugins/security_solution/server/endpoint/routes/metadata/metadata.test.ts

@@ -27,7 +27,6 @@ import {
 } from '../../../../common/endpoint/types';
 import { SearchResponse } from 'elasticsearch';
 import { registerEndpointRoutes } from './index';
-import * as data from '../../test_data/all_metadata_data.json';


jonathan-buttner · 2020-06-12T13:13:21Z

x-pack/test/functional/es_archives/endpoint/metadata/api_feature/data.json

@@ -17,7 +17,11 @@
 },
 "endpoint": {
 "policy": {
- "id": "C2A9093E-E289-4C0A-AA44-8C32A414FA7A"
+ "applied": {


Don't need to do it in this PR but we should probably gzip this file too.

…difrankie/kibana into EMT-401_add_policy_data_to_metadata

kibanamachine · 2020-06-12T15:58:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 827eefa

History

💚 Build #53507 succeeded 1642b7f
💛 Build #53491 was flaky 9fa55cd
💔 Build #53469 failed d5bdfa5
💔 Build #53449 failed 584f3cd
💔 Build #53429 failed ddfc3a3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#68582) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests

#68582) (#69046) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests

* master: (91 commits) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) [DOCS] Fixes POST request for saved objects (elastic#69036) ...

* master: (60 commits) Re-enable mistakenly skipped tests. (elastic#69123) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) ...

EMT-401: add policy data to metadata and fix tests

5319b2d

nnamdifrankie added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Jun 8, 2020

nnamdifrankie marked this pull request as ready for review June 9, 2020 14:07

nnamdifrankie requested review from a team as code owners June 9, 2020 14:07

nnamdifrankie requested review from jonathan-buttner and kevinlog June 9, 2020 14:07

EMT-401: clean up

889103e

oatkiller added the Feature:Endpoint Elastic Endpoint feature label Jun 9, 2020

Merge branch 'master' into EMT-401_add_policy_data_to_metadata

d201ae3

nnamdifrankie added v7.9.0 and removed v7.8.0 labels Jun 9, 2020

elasticmachine and others added 3 commits June 9, 2020 13:16

Merge branch 'master' into EMT-401_add_policy_data_to_metadata

3abdcd4

Merge branch 'master' into EMT-401_add_policy_data_to_metadata

ddfc3a3

EMT-401: fix linting

584f3cd

elasticmachine and others added 4 commits June 11, 2020 15:05

Merge branch 'master' into EMT-401_add_policy_data_to_metadata

48df79e

EMT-401: remove mapping files

dfe0bcc

Merge branch 'EMT-401_add_policy_data_to_metadata' of github.com:nnam…

d5bdfa5

…difrankie/kibana into EMT-401_add_policy_data_to_metadata

EMT-401: fix build

9fa55cd

Merge branch 'master' into EMT-401_add_policy_data_to_metadata

1642b7f

kevinlog approved these changes Jun 12, 2020

View reviewed changes

jonathan-buttner requested changes Jun 12, 2020

View reviewed changes

jonathan-buttner approved these changes Jun 12, 2020

View reviewed changes

nnamdifrankie added 2 commits June 12, 2020 10:19

EMT-401: update variable name

2d11769

Merge branch 'EMT-401_add_policy_data_to_metadata' of github.com:nnam…

827eefa

…difrankie/kibana into EMT-401_add_policy_data_to_metadata

nnamdifrankie merged commit c3d784c into elastic:master Jun 12, 2020

nnamdifrankie deleted the EMT-401_add_policy_data_to_metadata branch June 12, 2020 16:45

nnamdifrankie mentioned this pull request Jun 12, 2020

[7.x] [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (#68582) #69046

Merged

nnamdifrankie added a commit to nnamdifrankie/kibana that referenced this pull request Jun 12, 2020

[SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (

a5d4083

elastic#68582) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests

nnamdifrankie added a commit that referenced this pull request Jun 12, 2020

[SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (

3f5daeb

#68582) (#69046) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EMT-401: add policy data to metadata and fix tests #68582

EMT-401: add policy data to metadata and fix tests #68582

nnamdifrankie commented Jun 8, 2020 •

edited

Loading

elasticmachine commented Jun 9, 2020

nnamdifrankie commented Jun 9, 2020

charlie-pichette commented Jun 9, 2020

nnamdifrankie commented Jun 9, 2020

nnamdifrankie commented Jun 11, 2020

nnamdifrankie commented Jun 12, 2020

jonathan-buttner left a comment

jonathan-buttner Jun 12, 2020

jonathan-buttner Jun 12, 2020

nnamdifrankie Jun 12, 2020

nnamdifrankie Jun 12, 2020

jonathan-buttner Jun 12, 2020

jonathan-buttner Jun 12, 2020

kibanamachine commented Jun 12, 2020

EMT-401: add policy data to metadata and fix tests #68582

EMT-401: add policy data to metadata and fix tests #68582

Conversation

nnamdifrankie commented Jun 8, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Jun 9, 2020

nnamdifrankie commented Jun 9, 2020

charlie-pichette commented Jun 9, 2020

nnamdifrankie commented Jun 9, 2020

nnamdifrankie commented Jun 11, 2020

nnamdifrankie commented Jun 12, 2020

jonathan-buttner left a comment

Choose a reason for hiding this comment

jonathan-buttner Jun 12, 2020

Choose a reason for hiding this comment

jonathan-buttner Jun 12, 2020

Choose a reason for hiding this comment

nnamdifrankie Jun 12, 2020

Choose a reason for hiding this comment

nnamdifrankie Jun 12, 2020

Choose a reason for hiding this comment

jonathan-buttner Jun 12, 2020

Choose a reason for hiding this comment

jonathan-buttner Jun 12, 2020

Choose a reason for hiding this comment

kibanamachine commented Jun 12, 2020

💚 Build Succeeded

History

nnamdifrankie commented Jun 8, 2020 •

edited

Loading