[SIEM][Detections Engine] - Fix reference rule url overflow #68640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spong
approved these changes
Jun 10, 2020
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Jun 10, 2020
…68640) ### Summary Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
yctercero
added a commit
that referenced
this pull request
Jun 11, 2020
…68835) ### Summary Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 11, 2020
* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
Rule Details
Before
After
Rule Creation
Before
After
Checklist