Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved query modal overlay #68826

Merged

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jun 10, 2020

Summary

Before:
image
After:
image

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I can be of much help here, but it seems appropriate to close the popover when the modal is opened.

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.2 v7.8.1 v8.0.0 labels Jun 10, 2020
@patrykkopycinski patrykkopycinski marked this pull request as ready for review June 10, 2020 22:39
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner June 10, 2020 22:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@spong
Copy link
Member

spong commented Jun 10, 2020

Thanks for picking this one up @patrykkopycinski! 😀 Here's a related issue regarding the save query modal's z-index: #48124

And I agree with @cchaos that we should close the popover when the modal is open.

@XavierM XavierM removed the v7.7.2 label Jun 12, 2020
@cnasikas
Copy link
Member

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elastic/kibana-app-arch can I ask you take a look at this PR?

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write some tests to go with this? Thanks

@stephmilovic
Copy link
Contributor

Ok, 2 issues. When you delete the saved query, the timeline results clear:
disappears2

Can you please make it so that the modal is static instead of scrolling with the page:
scroll

@patrykkopycinski patrykkopycinski requested review from a team as code owners July 2, 2020 13:25
@patrykkopycinski
Copy link
Contributor Author

@stephmilovic Could you create a separate issue for #1?
#2 is going to be resolved by #69433

Added unit test

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test woohoooo! LGTM 🚀

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts.saved objects management saved objects edition page allows to delete a saved object

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/68400

[00:00:00]       │
[00:11:47]         └-: saved objects management
[00:11:47]           └-> "before all" hook
[00:11:47]           └-: saved objects edition page
[00:11:47]             └-> "before all" hook
[00:11:47]             └-> allows to update the saved object when submitting
[00:11:47]               └-> "before each" hook: global before each
[00:11:47]               └-> "before each" hook
[00:11:47]                 │ info [saved_objects_management/edit_saved_object] Loading "mappings.json"
[00:11:47]                 │ info [saved_objects_management/edit_saved_object] Loading "data.json"
[00:11:47]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana] creating index, cause [api], templates [], shards [1]/[0]
[00:11:47]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]])." previous.health="YELLOW" reason="shards started [[.kibana][0]]"
[00:11:47]                 │ info [saved_objects_management/edit_saved_object] Created index ".kibana"
[00:11:47]                 │ debg [saved_objects_management/edit_saved_object] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:11:47]                 │ info [saved_objects_management/edit_saved_object] Indexed 4 docs into ".kibana"
[00:11:47]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana/HTqlwcd1RAu0GPjjVMKmGQ] update_mapping [_doc]
[00:11:47]                 │ debg Migrating saved objects
[00:11:47]                 │ proc [kibana]   log   [20:36:00.520] [info][savedobjects-service] Creating index .kibana_2.
[00:11:47]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:11:47]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] updating number_of_replicas to [0] for indices [.kibana_2]
[00:11:48]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_2][0]]"
[00:11:48]                 │ proc [kibana]   log   [20:36:00.589] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:11:48]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:11:48]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] updating number_of_replicas to [0] for indices [.kibana_1]
[00:11:48]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:11:48]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] 3634 finished with response BulkByScrollResponse[took=25.7ms,timed_out=false,sliceId=null,updated=0,created=4,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:11:48]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana/HTqlwcd1RAu0GPjjVMKmGQ] deleting index
[00:11:48]                 │ proc [kibana]   log   [20:36:00.938] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:11:48]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/P2G9c8pLRFymmvuum3qZQQ] update_mapping [_doc]
[00:11:48]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/P2G9c8pLRFymmvuum3qZQQ] update_mapping [_doc]
[00:11:48]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/P2G9c8pLRFymmvuum3qZQQ] update_mapping [_doc]
[00:11:48]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/P2G9c8pLRFymmvuum3qZQQ] update_mapping [_doc]
[00:11:48]                 │ proc [kibana]   log   [20:36:01.081] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:11:48]                 │ proc [kibana]   log   [20:36:01.118] [info][savedobjects-service] Finished in 600ms.
[00:11:48]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:11:50]               │ debg navigating to settings url: http://localhost:6181/app/management
[00:11:50]               │ debg navigate to: http://localhost:6181/app/management
[00:11:50]               │ debg browser[INFO] http://localhost:6181/app/management?_t=1593722162584 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:11:50]               │
[00:11:50]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:50]               │ debg ... sleep(700) start
[00:11:50]               │ debg ... sleep(700) end
[00:11:50]               │ debg returned from get, calling refresh
[00:11:51]               │ debg browser[INFO] http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 444:106112 "INFO: 2020-07-02T20:36:03Z
[00:11:51]               │        Adding connection to http://localhost:6181/elasticsearch
[00:11:51]               │
[00:11:51]               │      "
[00:11:51]               │ERROR browser[SEVERE] http://localhost:6181/34296/bundles/core/core.entry.js 75:261771 TypeError: Failed to fetch
[00:11:51]               │          at Fetch._callee3$ (http://localhost:6181/34296/bundles/core/core.entry.js:26:104500)
[00:11:51]               │          at l (http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:360:1005347)
[00:11:51]               │          at Generator._invoke (http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:360:1005100)
[00:11:51]               │          at Generator.forEach.e.<computed> [as throw] (http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:360:1005704)
[00:11:51]               │          at fetch_asyncGeneratorStep (http://localhost:6181/34296/bundles/core/core.entry.js:26:98881)
[00:11:51]               │          at _throw (http://localhost:6181/34296/bundles/core/core.entry.js:26:99289)
[00:11:51]               │ debg browser[INFO] http://localhost:6181/app/management?_t=1593722162584 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:11:51]               │
[00:11:51]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:51]               │ debg currentUrl = http://localhost:6181/app/management
[00:11:51]               │          appUrl = http://localhost:6181/app/management
[00:11:51]               │ debg TestSubjects.find(kibanaChrome)
[00:11:51]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:11:53]               │ debg browser[INFO] http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 444:106112 "INFO: 2020-07-02T20:36:05Z
[00:11:53]               │        Adding connection to http://localhost:6181/elasticsearch
[00:11:53]               │
[00:11:53]               │      "
[00:11:53]               │ debg ... sleep(501) start
[00:11:53]               │ debg ... sleep(501) end
[00:11:53]               │ debg in navigateTo url = http://localhost:6181/app/management
[00:11:53]               │ debg TestSubjects.exists(statusPageContainer)
[00:11:53]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:11:56]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:11:56]               │ debg TestSubjects.click(objects)
[00:11:56]               │ debg Find.clickByCssSelector('[data-test-subj="objects"]') with timeout=10000
[00:11:56]               │ debg Find.findByCssSelector('[data-test-subj="objects"]') with timeout=10000
[00:11:56]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:11:56]               │ debg --- retry.try error: Waiting
[00:11:57]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:11:59]               │ debg --- retry.tryForTime error: *[data-test-subj="savedObjectsTable"] .euiBasicTable-loading is not displayed
[00:12:00]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:12:02]               │ debg --- retry.tryForTime error: *[data-test-subj="savedObjectsTable"] .euiBasicTable-loading is not displayed
[00:12:03]               │ debg TestSubjects.find(savedObjectsTable)
[00:12:03]               │ debg Find.findByCssSelector('[data-test-subj="savedObjectsTable"]') with timeout=10000
[00:12:03]               │ debg navigateToUrl http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:03]               │ debg browser[INFO] http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist?_t=1593722176081 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:12:03]               │
[00:12:03]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:12:03]               │ debg currentUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:03]               │          appUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:03]               │ debg TestSubjects.find(kibanaChrome)
[00:12:03]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:12:04]               │ debg TestSubjects.exists(savedObjectEditSave)
[00:12:04]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="savedObjectEditSave"]') with timeout=120000
[00:12:04]               │ debg browser[INFO] http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 444:106112 "INFO: 2020-07-02T20:36:17Z
[00:12:04]               │        Adding connection to http://localhost:6181/elasticsearch
[00:12:04]               │
[00:12:04]               │      "
[00:12:05]               │ debg TestSubjects.getAttribute(savedObjects-editField-title, value)
[00:12:05]               │ debg TestSubjects.find(savedObjects-editField-title)
[00:12:05]               │ debg Find.findByCssSelector('[data-test-subj="savedObjects-editField-title"]') with timeout=10000
[00:12:05]               │ debg TestSubjects.setValue(savedObjects-editField-title, Edited Dashboard)
[00:12:05]               │ debg TestSubjects.click(savedObjects-editField-title)
[00:12:05]               │ debg Find.clickByCssSelector('[data-test-subj="savedObjects-editField-title"]') with timeout=10000
[00:12:05]               │ debg Find.findByCssSelector('[data-test-subj="savedObjects-editField-title"]') with timeout=10000
[00:12:05]               │ debg TestSubjects.setValue(savedObjects-editField-description, Some description)
[00:12:05]               │ debg TestSubjects.click(savedObjects-editField-description)
[00:12:05]               │ debg Find.clickByCssSelector('[data-test-subj="savedObjects-editField-description"]') with timeout=10000
[00:12:05]               │ debg Find.findByCssSelector('[data-test-subj="savedObjects-editField-description"]') with timeout=10000
[00:12:05]               │ debg TestSubjects.find(savedObjectEditSave)
[00:12:05]               │ debg Find.findByCssSelector('[data-test-subj="savedObjectEditSave"]') with timeout=10000
[00:12:05]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:12:06]               │ debg --- retry.try error: Waiting
[00:12:06]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:12:09]               │ debg --- retry.tryForTime error: *[data-test-subj="savedObjectsTable"] .euiBasicTable-loading is not displayed
[00:12:09]               │ debg TestSubjects.find(savedObjectsTable)
[00:12:09]               │ debg Find.findByCssSelector('[data-test-subj="savedObjectsTable"]') with timeout=10000
[00:12:09]               │ debg navigateToUrl http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:09]               │ debg browser[INFO] http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist?_t=1593722182387 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:12:09]               │
[00:12:09]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:12:09]               │ debg currentUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:09]               │          appUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:09]               │ debg TestSubjects.find(kibanaChrome)
[00:12:09]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:12:10]               │ debg TestSubjects.getAttribute(savedObjects-editField-title, value)
[00:12:10]               │ debg TestSubjects.find(savedObjects-editField-title)
[00:12:10]               │ debg Find.findByCssSelector('[data-test-subj="savedObjects-editField-title"]') with timeout=10000
[00:12:10]               │ debg browser[INFO] http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 444:106112 "INFO: 2020-07-02T20:36:23Z
[00:12:10]               │        Adding connection to http://localhost:6181/elasticsearch
[00:12:10]               │
[00:12:10]               │      "
[00:12:11]               │ debg TestSubjects.getAttribute(savedObjects-editField-description, value)
[00:12:11]               │ debg TestSubjects.find(savedObjects-editField-description)
[00:12:11]               │ debg Find.findByCssSelector('[data-test-subj="savedObjects-editField-description"]') with timeout=10000
[00:12:11]               └- ✓ pass  (21.3s) "saved objects management saved objects edition page allows to update the saved object when submitting"
[00:12:11]             └-> "after each" hook
[00:12:11]               │ info [saved_objects_management/edit_saved_object] Unloading indices from "mappings.json"
[00:12:11]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/P2G9c8pLRFymmvuum3qZQQ] deleting index
[00:12:11]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_1/Gqw_e7NMSeOlrmScYn-t4w] deleting index
[00:12:11]               │ info [saved_objects_management/edit_saved_object] Deleted existing index [".kibana_2",".kibana_1"]
[00:12:11]               │ info [saved_objects_management/edit_saved_object] Unloading indices from "data.json"
[00:12:11]             └-> allows to delete a saved object
[00:12:11]               └-> "before each" hook: global before each
[00:12:11]               └-> "before each" hook
[00:12:11]                 │ info [saved_objects_management/edit_saved_object] Loading "mappings.json"
[00:12:11]                 │ info [saved_objects_management/edit_saved_object] Loading "data.json"
[00:12:11]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana] creating index, cause [api], templates [], shards [1]/[0]
[00:12:11]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]])." previous.health="YELLOW" reason="shards started [[.kibana][0]]"
[00:12:11]                 │ info [saved_objects_management/edit_saved_object] Created index ".kibana"
[00:12:11]                 │ debg [saved_objects_management/edit_saved_object] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:12:11]                 │ info [saved_objects_management/edit_saved_object] Indexed 4 docs into ".kibana"
[00:12:11]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana/2KFQc1TGSeO4dNHHBnfMFQ] update_mapping [_doc]
[00:12:11]                 │ debg Migrating saved objects
[00:12:11]                 │ proc [kibana]   log   [20:36:24.092] [info][savedobjects-service] Creating index .kibana_2.
[00:12:11]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:12:11]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] updating number_of_replicas to [0] for indices [.kibana_2]
[00:12:11]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_2][0]]"
[00:12:11]                 │ proc [kibana]   log   [20:36:24.159] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:12:11]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:12:11]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] updating number_of_replicas to [0] for indices [.kibana_1]
[00:12:11]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:12:11]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] 3877 finished with response BulkByScrollResponse[took=24.7ms,timed_out=false,sliceId=null,updated=0,created=4,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:12:11]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana/2KFQc1TGSeO4dNHHBnfMFQ] deleting index
[00:12:11]                 │ proc [kibana]   log   [20:36:24.504] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:12:11]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/F5V7gilhT2WR5lnU3mlV8g] update_mapping [_doc]
[00:12:11]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/F5V7gilhT2WR5lnU3mlV8g] update_mapping [_doc]
[00:12:12]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/F5V7gilhT2WR5lnU3mlV8g] update_mapping [_doc]
[00:12:12]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1593720152130015240] [.kibana_2/F5V7gilhT2WR5lnU3mlV8g] update_mapping [_doc]
[00:12:12]                 │ proc [kibana]   log   [20:36:24.638] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:12:12]                 │ proc [kibana]   log   [20:36:24.700] [info][savedobjects-service] Finished in 609ms.
[00:12:12]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:12:13]               │ debg navigateToUrl http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:13]               │ debg browser[INFO] http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist?_t=1593722186150 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:12:13]               │
[00:12:13]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:12:13]               │ debg currentUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:13]               │          appUrl = http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:13]               │ debg TestSubjects.find(kibanaChrome)
[00:12:13]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:12:14]               │ debg TestSubjects.find(savedObjectEditDelete)
[00:12:14]               │ debg Find.findByCssSelector('[data-test-subj="savedObjectEditDelete"]') with timeout=10000
[00:12:14]               │ debg browser[INFO] http://localhost:6181/34296/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 444:106112 "INFO: 2020-07-02T20:36:27Z
[00:12:14]               │        Adding connection to http://localhost:6181/elasticsearch
[00:12:14]               │
[00:12:14]               │      "
[00:12:15]               │ debg Clicking modal confirm
[00:12:15]               │ debg TestSubjects.exists(confirmModalTitleText)
[00:12:15]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="confirmModalTitleText"]') with timeout=2500
[00:12:15]               │ debg TestSubjects.click(confirmModalConfirmButton)
[00:12:15]               │ debg Find.clickByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:12:15]               │ debg Find.findByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:12:15]               │ debg TestSubjects.exists(confirmModalTitleText)
[00:12:15]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="confirmModalTitleText"]') with timeout=2500
[00:12:17]               │ debg browser[INFO] http://localhost:6181/34296/bundles/core/core.entry.js 75:262850 "Detected an unhandled Promise rejection.
[00:12:17]               │      TypeError: Cannot read property 'attributes' of undefined"
[00:12:17]               │ERROR browser[SEVERE] http://localhost:6181/34296/bundles/plugin/savedObjectsManagement/1.plugin.js 5:34045 Uncaught TypeError: Cannot read property 'attributes' of undefined
[00:12:17]               │ debg --- retry.tryForTime error: [data-test-subj="confirmModalTitleText"] is not displayed
[00:12:18]               │ debg Find.existsByDisplayedByCssSelector('*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading') with timeout=2500
[00:12:20]               │ debg --- retry.tryForTime error: *[data-test-subj="savedObjectsTable"] .euiBasicTable-loading is not displayed
[00:12:21]               │ debg TestSubjects.find(savedObjectsTable)
[00:12:21]               │ debg Find.findByCssSelector('[data-test-subj="savedObjectsTable"]') with timeout=10000
[00:12:31]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/saved objects management saved objects edition page allows to delete a saved object.png"
[00:12:31]               │ info Current URL is: http://localhost:6181/app/management/kibana/objects/savedDashboards/i-exist
[00:12:31]               │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/saved objects management saved objects edition page allows to delete a saved object.html
[00:12:31]               └- ✖ fail: "saved objects management saved objects edition page allows to delete a saved object"
[00:12:31]               │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="savedObjectsTable"])
Wait timed out after 10013ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 5fcf803 into elastic:master Jul 2, 2020
@patrykkopycinski patrykkopycinski deleted the fix/saved-query-overlay branch July 2, 2020 21:48
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 2, 2020
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 2, 2020
# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/query_bar/index.test.tsx
patrykkopycinski added a commit that referenced this pull request Jul 3, 2020
# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/query_bar/index.test.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 3, 2020
* master: (32 commits)
  [Ingest Pipelines] Load from json (elastic#70297)
  [Rum Dashbaord] Rum selected service view (elastic#70579)
  [Uptime] Prevent duplicate requests on load for index status (elastic#70585)
  [ML] Changing shared module setup function parameters (elastic#70589)
  [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676)
  [Alerting] document requirements for developing new action types (elastic#69164)
  Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028)
  [Maps] show vector tile labels on top (elastic#69444)
  chore(NA): upgrade to lodash@4 (elastic#69868)
  Add Snapshot Restore README with quick-testing steps. (elastic#70494)
  [EPM] Use higher priority than default templates (elastic#70640)
  [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621)
  [kbn/optimizer] only build specified themes (elastic#70389)
  Fix saved query modal overlay (elastic#68826)
  Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633)
  [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634)
  fix 400 error on initial signals search (elastic#70618)
  [Maps] fix unable to edit heatmap metric (elastic#70606)
  Update network idle timeout (elastic#70629)
  [APM] Disable flaky useFetcher test (elastic#70638)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.1 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.