Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert vis_type_vega to Typescript #68915

Merged
merged 61 commits into from
Jul 15, 2020
Merged

Convert vis_type_vega to Typescript #68915

merged 61 commits into from
Jul 15, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Jun 11, 2020 •
edited
Loading

Summary

Makes progress on #65839

  • Converted data in vis_type_vega to Typescript

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ashikmeerankutty ashikmeerankutty requested a review from a team June 11, 2020 16:47
@ashikmeerankutty ashikmeerankutty requested a review from a team as a code owner June 11, 2020 16:47
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ashikmeerankutty ashikmeerankutty changed the title Convert typescript Convert vis_type_vega to Typescript Jun 11, 2020
@lukeelmers lukeelmers added review Team:AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added the Feature:Vega Vega visualizations label Jun 11, 2020
@ashikmeerankutty ashikmeerankutty requested a review from a team as a code owner June 12, 2020 09:45
@flash1293 flash1293 added v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed Team:AppArch labels Jul 9, 2020
@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

Sure @flash1293 :)

@stratoula
Copy link
Contributor

Jenkins, test this

@stratoula stratoula self-requested a review July 13, 2020 12:12
stratoula
stratoula approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it locally on Safari and FF and the functionality is not broken. I think that a good job has been done to type the majority of the code. Thank you @ashikmeerankutty for taking care of it 🍪

@timroes timroes mentioned this pull request Jul 14, 2020
Closed
20 tasks
flash1293
flash1293 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code again and this LGTM. Thanks again for going through this, great improvement for the Kibana code base!

@flash1293 flash1293 added v7.10.0 and removed v7.9.0 labels Jul 14, 2020
@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

7.9 will be branched off today or tomorrow, I will hold this PR back till this is done, so the change will go into 7.10

I'm doing this so we have another minor of testing whether anything broke - as this is not adding any features, there's no benefit to squeezing it into 7.9

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

Jenkins, test this.

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

Jenkins, this this.

@stratoula
Copy link
Contributor

Jenkins test, this.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
visTypeVega 2.1MB +4.0KB 2.1MB

miscellaneous assets size

id value diff baseline
upgradeAssistant 22.6KB +19.0B 22.5KB
visTypeVega 228.2KB +113.0B 228.1KB
total - +132.0B -

page load bundle size

id value diff baseline
visTypeVega 631.8KB +381.0B 631.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 5f6389a into elastic:master Jul 15, 2020
@flash1293 flash1293 mentioned this pull request Jul 15, 2020
Merged
flash1293 pushed a commit to flash1293/kibana that referenced this pull request Jul 15, 2020
@ashikmeerankutty @flash1293
Convert vis_type_vega to Typescript (elastic#68915)
a65abc0
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 15, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
d6616db 
* master:
  [Form lib] Memoize form hook object and fix hook array deps (elastic#71237)
  [uiActions] Support emitting nested triggers and actions (elastic#70602)
  add short sleep before clicking Remove on sample data (elastic#71104)
  Fixed the beta badge layout. (elastic#71835)
  Restores task for downloading Chromium builds (elastic#71749)
  [logging] Format new platform json logging to ECS (elastic#71138)
  add policy details and update SO limit requests (elastic#71789)
  Convert vis_type_vega to Typescript (elastic#68915)
  [ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane (elastic#71839)
flash1293 added a commit that referenced this pull request Jul 15, 2020
@flash1293
Convert vis_type_vega to Typescript (#68915) (#71863)
ac0760b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers left review comments

@flash1293 flash1293 flash1293 approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@flash1293 flash1293

Labels
💝community Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashikmeerankutty @kibanamachine @elasticmachine @flash1293 @stratoula @lukeelmers