[APM] Service map fix missing ML health indicators for camelCased services #68979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ML job group names.
ogupte
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
sorenlouv
approved these changes
Jun 12, 2020
sorenlouv
reviewed
Jun 12, 2020
| if (!serviceName) { | ||
| // APM ML job service was not found | ||
| return; | ||
| } | ||
| const serviceGroupName = encodeForMlApi(serviceName); |
There was a problem hiding this comment.
nit
Suggested change
| const serviceGroupName = encodeForMlApi(serviceName); | |
| const encodedServiceName = encodeForMlApi(serviceName); |
sorenlouv
reviewed
Jun 12, 2020
| encodeForMlApi(serviceName), | ||
| serviceName, | ||
| ]) | ||
| ); | ||
| const apmJobGroups = mlJob.groups.filter( | ||
| (groupName) => groupName !== APM_ML_JOB_GROUP_NAME | ||
| ); | ||
| if (apmJobGroups.length === mlJob.groups.length) { |
There was a problem hiding this comment.
I think this would read better as:
const hasApmGroup = mlJob.groups.some(
(groupName) => groupName !== APM_ML_JOB_GROUP_NAME
);
if (!hasApmGroup) {
// ML job missing "apm" group
return;
}
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jun 12, 2020
…vices (elastic#68979) * Closes elastic#68978 by encoding service names before comparing them to ML job group names. * Code tweak for readbility Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jun 12, 2020
…vices (elastic#68979) * Closes elastic#68978 by encoding service names before comparing them to ML job group names. * Code tweak for readbility Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68978 by encoding service names before comparing them to ML job group names.