Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] skip status.allowAnonymous tests on cloud #69017

Merged
merged 6 commits into from
Jun 26, 2020
Merged

[test] skip status.allowAnonymous tests on cloud #69017

merged 6 commits into from
Jun 26, 2020

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jun 12, 2020

Closes #51453

kibana.yml setting status.allowAnonymous will disable auth on the status index.html. When testing against cloud, this setting is not configurable and the test will always fail. This is expected behavior, and we have other tests for the auth portion so adding the skip-cloud label should be fine here.

@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels Jun 12, 2020
@jbudz jbudz requested a review from liza-mae June 12, 2020 14:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

liza-mae
liza-mae approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmlemeshko
dmlemeshko reviewed Jun 12, 2020
View reviewed changes
x-pack/test/functional/apps/status_page/status_page.ts Outdated
@@ -18,6 +18,7 @@ export default function statusPageFunctonalTests({
after(async () => await esArchiver.unload('empty_kibana'));

it('allows user to navigate without authentication', async () => {
this.tags(['skipCloud']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I know tags works only for describe context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmlemeshko great catch, yes the tag needs to be moved to describe.

liza-mae
liza-mae suggested changes Jun 13, 2020
View reviewed changes
x-pack/test/functional/apps/status_page/status_page.ts Outdated
@@ -18,6 +18,7 @@ export default function statusPageFunctonalTests({
after(async () => await esArchiver.unload('empty_kibana'));

it('allows user to navigate without authentication', async () => {
this.tags(['skipCloud']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmlemeshko great catch, yes the tag needs to be moved to describe.

@jbudz
Copy link
Member Author

jbudz commented Jun 18, 2020

@elasticmachine merge upstream

liza-mae
liza-mae reviewed Jun 23, 2020
View reviewed changes
x-pack/test/functional/apps/status_page/status_page.ts Outdated
@@ -14,6 +14,7 @@ export default function statusPageFunctonalTests({

describe('Status Page', function () {
this.tags('includeFirefox');
this.tags(['skipCloud']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to include tag above, this.tags(['skipCloud', 'includeFirefox']);

@jbudz
Copy link
Member Author

jbudz commented Jun 25, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Jun 26, 2020

Was asked to merge in slack after fixing ^. Merging away.

@jbudz jbudz merged commit 0f9efa8 into elastic:master Jun 26, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 26, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
17fba6a 
* master: (34 commits)
  Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054)
  [License Management] Do not break when `telemetry.enabled:false` (elastic#69711)
  [SECURITY] Redirect app/security to app/security/overview (elastic#70005)
  "Explore underlying data" in-chart action (elastic#69494)
  Api reference docs for state_containers and state_sync (elastic#67354)
  prep state transfer for passing embeddables by value to editor and back (elastic#69991)
  move Metrics API to start (elastic#69787)
  refactor: 💡 fix typo in embeddable (elastic#69417)
  [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982)
  [APM]Create API to return data to be used on the Overview page (elastic#69137)
  [Lens] Fix delete button position in dimension panel for long labels (elastic#69495)
  [Lens] Add toolbar api (elastic#69263)
  Fixes bug on color picker defaults on TSVB (elastic#69889)
  [DOCS] Fixes wording in Upload a CSV section (elastic#69969)
  [Discover] Validate timerange before submitting query to ES (elastic#69363)
  [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723)
  [Maps] Fix icon palettes are not working (elastic#69937)
  [Ingest Manager] Fix typo in constant name (elastic#69919)
  [test] skip status.allowAnonymous tests on cloud (elastic#69017)
  Fix backport (elastic#70003)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 26, 2020
@jloleysens
Merge branch 'ingest-pipelines/editor-dropzone-refinement' into inges…
36645ca 
…t-pipelines/editor-error-messages

* ingest-pipelines/editor-dropzone-refinement: (122 commits)
  Fixes for monaco XJSON grammar parser and update form copy
  Added cancel move button
  Refactor SCSS values to variables
  use classNames as it is intended to be used
  Remove box shadow on all nested tree items
  Rename variables and prefix booleans with "is"
  Fixes bug on color picker defaults on TSVB (elastic#69889)
  [DOCS] Fixes wording in Upload a CSV section (elastic#69969)
  [Discover] Validate timerange before submitting query to ES (elastic#69363)
  [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723)
  [Maps] Fix icon palettes are not working (elastic#69937)
  [Ingest Manager] Fix typo in constant name (elastic#69919)
  [test] skip status.allowAnonymous tests on cloud (elastic#69017)
  Fix backport (elastic#70003)
  [Reporting] ReportingStore module (elastic#69426)
  Add reporting assets to the eslint ignore file (elastic#69968)
  [Discover] set minBarHeight for high cardinality data (elastic#69875)
  Add featureUsage API to licensing context provider (elastic#69838)
  Fix uncaught typecheck merge conflict (elastic#70001)
  Use TS to discourage SO mappings with dynamic: false / dynamic: true (elastic#69927)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69017 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69017 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69017 or prevent reminders by adding the backport:skip label.

@liza-mae
Copy link
Contributor

liza-mae commented Jul 2, 2020

@jbudz @tylersmalley can we get this backported?

jbudz added a commit that referenced this pull request Jul 2, 2020
@jbudz @elasticmachine
[test] skip status.allowAnonymous tests on cloud (#69017)
0945585 
* skip cloud status page

* move skipcloud to describe block

* merge includeFireFox and skipCloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jbudz added a commit that referenced this pull request Jul 2, 2020
@jbudz @elasticmachine
[test] skip status.allowAnonymous tests on cloud (#69017)
cd37c33 
* skip cloud status page

* move skipcloud to describe block

* merge includeFireFox and skipCloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jbudz jbudz added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 2, 2020
@jbudz
Copy link
Member Author

jbudz commented Jul 2, 2020

7.x: 0945585
7.8: cd37c33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae requested changes

@dmlemeshko dmlemeshko dmlemeshko left review comments

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@jbudz @elasticmachine @kibanamachine @liza-mae @tylersmalley @dmlemeshko