[APM] Fix service maps not loading when there are no APM ML jobs

[ogupte]

Closes #69238 by handling 404 thrown error from the query for APM ML jobs.

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[dgieselaar]

for readability's sake, should we set apmMlJobs to [] and return (outside of the try/catch) if apmMlJobs.length === 0?

[sorenlouv]

I must admit, I found it more readable to return from the catch but either works.

[dgieselaar]

LGTM, just a suggestion

[sorenlouv]

Thinking more about this: I don't think we should silently swallow any error that occurs. Would be better if we can catch the error and only return under the right circumstances, and re-throw if not.

[sorenlouv]

WDYT about extracting to a separate function:

function getAnomalyDetectionJobs(): AnomalyDetectionJob[] {
  try {
    const { jobs } = await ml.anomalyDetectors.jobs(APM_ML_JOB_GROUP_NAME);
    return jobs;
  } catch (error) {
    // pseudo code
    if (error.code === 404) {
      return [];
    }
    throw error;
  }
}

[smith]

I don't think we should silently swallow any error that occurs. Would be better if we can catch the error and only return under the right circumstances, and re-throw if not.

+10000 to this.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2181b40

Build metrics

✅ unchanged

History

• 💚 Build #54278 succeeded 3b8d771

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream