Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster #69348

Merged
merged 36 commits into from
Jun 30, 2020

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Jun 16, 2020

Summary

Add the pipeline attr to the final payload when indexing to a "coverage" index, not a "totals" index.
Also:
We want 2 additional indexes, for R & D.
This pr allows us to add garbage data to the indexes for research,
w/o disturbing continuity on the "prod" indexes.

@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage labels Jun 16, 2020
@wayneseymour wayneseymour self-assigned this Jun 16, 2020
@wayneseymour
Copy link
Member Author

Testing: https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/13/

@wayneseymour
Copy link
Member Author

@wayneseymour
Copy link
Member Author

@wayneseymour wayneseymour changed the title [QA] [Code Coverage] Add Research and Development Indexes [QA] [Code Coverage] Add Research and Development Indexes and Cluster Jun 18, 2020
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@dmlemeshko
Copy link
Member

@elasticmachine merge upstream

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, several nits

vars/kibanaCoverage.groovy Outdated Show resolved Hide resolved
src/dev/code_coverage/ingest_coverage/ingest.js Outdated Show resolved Hide resolved
@wayneseymour
Copy link
Member Author

Looks good, several nits

What's a nit? :)

@wayneseymour
Copy link
Member Author

@dmlemeshko
Copy link
Member

Looks good, several nits

What's a nit? :)

a trivial detail :)

@LeeDr
Copy link

LeeDr commented Jun 30, 2020

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the arguments that should be quoted

vars/kibanaCoverage.groovy Outdated Show resolved Hide resolved
the ES queue size.
Error:

12:14:44  ### Orig Err:
12:14:44  {
12:14:44    "root_cause": [
12:14:44      {
12:14:44        "type": "es_rejected_execution_exception",
12:14:44        "reason": "rejected execution of org.elasticsearch.ingest.IngestService$3@373f5932 on EsThreadPoolExecutor[name = instance-0000000015/write, queue capacity = 200, org.elasticsearch.common.util.concurrent.EsThreadPoolExecutor@759beb77[Running, pool size = 2, active threads = 2, queued tasks = 199, completed tasks = 695890]]"
12:14:44      }
@wayneseymour
Copy link
Member Author

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour wayneseymour added the backport:skip This commit does not require backporting label Jun 30, 2020
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've seen the various parts of this work. Most importantly, the team assignment pipeline

@wayneseymour wayneseymour merged commit 175bdb5 into master Jun 30, 2020
@wayneseymour wayneseymour deleted the code-coverage-r-and-d-indexes branch June 30, 2020 23:00
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
…Research and Development Indexes and Cluster (elastic#69348)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 1, 2020
…-based-rbac

* upstream/master: (38 commits)
  Move logger configuration integration test to jest (elastic#70378)
  Changes observability plugin codeowner (elastic#70439)
  update (elastic#70424)
  [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179)
  Enable "Explore underlying data" actions for Lens visualizations (elastic#70047)
  Initial work on uptime homepage API (elastic#70135)
  expressions indexPattern function (elastic#70315)
  [Discover] Deangularization context error message refactoring (elastic#70090)
  [Lens] Add "no data" popover (elastic#69147)
  [Lens] Move chart switcher over (elastic#70182)
  chore: add missing mjs extension (elastic#70326)
  [Lens] Multiple y axes (elastic#69911)
  skip flaky suite (elastic#70386)
  fix bug to add timeline to case (elastic#70343)
  [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198)
  [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348)
  [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260)
  Resolver refactoring (elastic#70312)
  [Ingest Manager] Fix agent ack after input format change (elastic#70335)
  [eslint][ts] Enable prefer-ts-expect-error (elastic#70022)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants