[ML] DF Analytics: Creation wizard part 3 #69456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jun 18, 2020
| testData.job as DataFrameAnalyticsConfig | ||
| ); | ||
| }); | ||
|
|
||
| it('should have disabled Create button on open', async () => { | ||
| expect(await ml.dataFrameAnalyticsCreation.isCreateButtonDisabled()).to.be(true); | ||
| it('continues to the additional options step', async () => { |
There was a problem hiding this comment.
Nit - we try and start all these test descriptions with should now.
| ); | ||
| }); | ||
|
|
||
| it('continues to the details step', async () => { |
There was a problem hiding this comment.
Nit - as above, can this start with should? Applies to a few other tests in this file.
alvarezmelissa87
force-pushed
the
ml-dfanalytics-wizard-part-three
branch
from
3b7031c
to
758809e
Compare
walterra
reviewed
Jun 24, 2020
...ata_frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
Outdated
Show resolved
Hide resolved
...ata_frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
Outdated
Show resolved
Hide resolved
...ata_frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
Show resolved
Hide resolved
.../data_frame_analytics/pages/analytics_creation/components/advanced_step/hyper_parameters.tsx
Outdated
Show resolved
Hide resolved
...ame_analytics/pages/analytics_creation/components/advanced_step/outlier_hyper_parameters.tsx
Outdated
Show resolved
Hide resolved
...lication/data_frame_analytics/pages/analytics_creation/components/shared/get_explain_data.ts
Outdated
Show resolved
Hide resolved
alvarezmelissa87
force-pushed
the
ml-dfanalytics-wizard-part-three
branch
from
8837c39
to
e21c0f8
Compare
alvarezmelissa87
force-pushed
the
ml-dfanalytics-wizard-part-three
branch
from
e21c0f8
to
48dd0b8
Compare
|
retest |
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jun 25, 2020
* update clone tests * validate advanced params with explain * disable button while fetching validation data * comment out clone tests for now
60 tasks
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 25, 2020
* master: (45 commits) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) [ML] DF Analytics: Creation wizard part 3 (elastic#69456) Update Resolver generator script documentation (elastic#69912) [ML] Changes View results button text on new job page (elastic#69809) Add master branch to backport config (elastic#69893) [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761) unskips 'Events columns' test (elastic#69684) [ML] Changes the ML overview empty analytics panel text (elastic#69801) [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812) add the `exactRoute` property to app registration (elastic#69772) Bump backport to 5.4.6 (elastic#69880) [Logs UI] ML log integration splash screen (elastic#69288) Clean up TSVB type client code to conform to the schema (elastic#68519) ...
alvarezmelissa87
added a commit
that referenced
this pull request
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #66661
This is a follow up PR for switching over to the new creation wizard.
This PR adds validation to the advanced and hyper parameters in step two of the creation wizard. The fields values are validated against the explain API and errors are shown below the relevant field. The continue button is disabled until the field is valid.
This PR begins update of the cloning functional tests but they will not run yet. They will be addressed in a follow up so I can get the other changes in.
NOTE:
Follow up for advanced parameters:
Follow up for excludes table:
Checklist
Delete any items that are not applicable to this PR.