[6.8] Redirect to Logged Out UI on SAML Logout Response. #69815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
force-pushed
the
6.8-issue-xxx-saml-logout-response
branch
from
656523d
to
4a898eb
Compare
azasypkin
commented
Jun 24, 2020
| @@ -423,7 +431,7 @@ export class SAMLAuthenticationProvider { | |||
| return DeauthenticationResult.redirectTo(redirect); | |||
| } | |||
|
|
|||
| return DeauthenticationResult.redirectTo('/logged_out'); | |||
| return DeauthenticationResult.redirectTo(`${this._options.basePath}/logged_out`); | |||
There was a problem hiding this comment.
note: looks like we always had this bug 🙈
|
@legrego same here - almost the same logic as in the original PR - but code is different. Would you mind taking a look whenever you have time? Thanks! |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
ACK: will review tomorrow morning |
legrego
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #69676