Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Remove broken button #69853

Merged
merged 2 commits into from
Jun 25, 2020
Merged

[Maps] Remove broken button #69853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba348ad
remove broken button
thomasneirynck Jun 24, 2020
247d00c
remove translations
thomasneirynck Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions x-pack/plugins/maps/public/connected_components/layer_panel/__snapshots__/view.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions x-pack/plugins/maps/public/connected_components/layer_panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import { connect } from 'react-redux';
import { LayerPanel } from './view';
import { getSelectedLayer } from '../../selectors/map_selectors';
import { fitToLayerExtent, updateSourceProp } from '../../actions';
import { updateSourceProp } from '../../actions';

function mapStateToProps(state = {}) {
const selectedLayer = getSelectedLayer(state);
Expand All @@ -19,9 +19,6 @@ function mapStateToProps(state = {}) {

function mapDispatchToProps(dispatch) {
return {
fitToBounds: (layerId) => {
dispatch(fitToLayerExtent(layerId));
},
updateSourceProp: (id, propName, value, newLayerType) =>
dispatch(updateSourceProp(id, propName, value, newLayerType)),
};
Expand Down
16 changes: 2 additions & 14 deletions x-pack/plugins/maps/public/connected_components/layer_panel/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { LayerErrors } from './layer_errors';
import { LayerSettings } from './layer_settings';
import { StyleSettings } from './style_settings';
import {
EuiButtonIcon,
EuiIcon,
EuiFlexItem,
EuiTitle,
EuiPanel,
Expand All @@ -27,7 +27,6 @@ import {
} from '@elastic/eui';

import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
import { KibanaContextProvider } from '../../../../../../src/plugins/kibana_react/public';
import { Storage } from '../../../../../../src/plugins/kibana_utils/public';

Expand Down Expand Up @@ -175,18 +174,7 @@ export class LayerPanel extends React.Component {
<EuiFlyoutHeader hasBorder className="mapLayerPanel__header">
<EuiFlexGroup responsive={false} alignItems="center" gutterSize="s">
<EuiFlexItem grow={false}>
<EuiButtonIcon
aria-label={i18n.translate('xpack.maps.layerPanel.fitToBoundsAriaLabel', {
defaultMessage: 'Fit to bounds',
})}
iconType={selectedLayer.getLayerTypeIconName()}
onClick={this.props.fitToBounds}
>
<FormattedMessage
id="xpack.maps.layerPanel.fitToBoundsButtonLabel"
defaultMessage="Fit"
/>
</EuiButtonIcon>
<EuiIcon type={selectedLayer.getLayerTypeIconName()} />
</EuiFlexItem>
<EuiFlexItem>
<EuiTitle size="s">
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9001,8 +9001,6 @@
"xpack.maps.layerPanel.filterEditor.emptyState.description": "フィルターを追加してレイヤーデータを絞ります。",
"xpack.maps.layerPanel.filterEditor.queryBarSubmitButtonLabel": "フィルターを設定",
"xpack.maps.layerPanel.filterEditor.title": "フィルタリング",
"xpack.maps.layerPanel.fitToBoundsAriaLabel": "境界に合わせる",
"xpack.maps.layerPanel.fitToBoundsButtonLabel": "合わせる",
"xpack.maps.layerPanel.footer.cancelButtonLabel": "キャンセル",
"xpack.maps.layerPanel.footer.closeButtonLabel": "閉じる",
"xpack.maps.layerPanel.footer.removeLayerButtonLabel": "レイヤーを削除",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9005,8 +9005,6 @@
"xpack.maps.layerPanel.filterEditor.emptyState.description": "添加筛选以缩小图层数据范围。",
"xpack.maps.layerPanel.filterEditor.queryBarSubmitButtonLabel": "设置筛选",
"xpack.maps.layerPanel.filterEditor.title": "筛选",
"xpack.maps.layerPanel.fitToBoundsAriaLabel": "适应边界",
"xpack.maps.layerPanel.fitToBoundsButtonLabel": "适应",
"xpack.maps.layerPanel.footer.cancelButtonLabel": "取消",
"xpack.maps.layerPanel.footer.closeButtonLabel": "关闭",
"xpack.maps.layerPanel.footer.removeLayerButtonLabel": "移除图层",
Expand Down