[Dashboard] Add visualization by value to dashboard #69898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
June 17, 2020 12:23
majagrubic
changed the title
majagrubic
force-pushed
the
add-vis-to-dashboard-app-communication
branch
2 times, most recently
from
a1000cf
to
fb45797
Compare
majagrubic
force-pushed
the
add-vis-to-dashboard-app-communication
branch
from
fb45797
to
d5bce1f
Compare
5 tasks
majagrubic
added
v8.0.0
v7.9.0
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
ThomThomson
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Tested on Chrome and Firefox. Everything works as expected, LGTM!
As discussed, in this PR edit visualization doesn't appear as an option on visualizations which were added by value, but this only happens when the feature flag is turned on, so it won't disrupt normal functionality. Additionally, a followup PR will address this.
src/plugins/dashboard/public/application/dashboard_app_controller.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
June 26, 2020 13:25
stratoula
approved these changes
Jun 29, 2020
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 30, 2020
* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes # Conflicts: # scripts/functional_tests.js # tasks/function_test_groups.js
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 30, 2020
* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes # Conflicts: # scripts/functional_tests.js # tasks/function_test_groups.js
majagrubic
pushed a commit
that referenced
this pull request
Jun 30, 2020
* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes # Conflicts: # scripts/functional_tests.js # tasks/function_test_groups.js
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes
|
@majagrubic how do I test this PR on 7.9.0 please? Thanks! |
|
@bhavyarm Maja is out this week. This feature is behind a flag. You have to set |
|
@flash1293 thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of: #68902
The functionality is the same as in the above-mentioned PR, with a difference that this PR incorporates changes of the new state transfer and removes the hack of passing the dashboard input around.
Reminder: to test this locally, you'll need to set the
showNewVisualizeFlowflag to true invisualize/config.ts:https://github.com/elastic/kibana/pull/68902/files#diff-fce45a432f9c2a705ffc1f2b16fce071R23
Without the flag set, there should be no changes to the existing flow.
Note: Editing visualization does not work yet, will tackle that in a separate PR, to keep this one brief and short.
Tracking issue: https://github.com/elastic/kibana-team/issues/231
Checklist
Delete any items that are not applicable to this PR.
- [] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers