New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for upgrade assistant functional test to incorporate test user #70071

Merged

rashmivkulkarni merged 20 commits into elastic:master from rashmivkulkarni:upgrade_assistant

Jul 23, 2020

Contributor

rashmivkulkarni commented Jun 26, 2020

Ref meta issue: #60815

Summary
This PR replaces elastic superuser with test_user with minimum privileges assigned to the test_user.

New role created : global_upgrade_assistant_role
Checklist

Unit or functional tests were updated or added to match the most common scenarios


          changes for upgrade assistant functional test to incorporate test user

bad7e81

rashmivkulkarni added test_xpack_functional v8.0.0 release_note:skip Feature:Upgrade Assistant v7.9.0 labels

rashmivkulkarni self-assigned this

Contributor

jloleysens commented Jun 26, 2020

@elasticmachine merge upstream

elasticmachine and others added 4 commits

June 26, 2020 08:01


          Merge branch 'master' into upgrade_assistant

71bdcc9


          Merge branch 'master' of github.com:elastic/kibana into upgrade_assis…

3d58783

…tant


          changes to toggle on/off

fe79a6d


          Merge branch 'upgrade_assistant' of github.com:rasroh/kibana into upg…

7cf0199

…rade_assistant

rashmivkulkarni mentioned this pull request

[Meta] FTR configurable test users for xpack #60815

Closed

68 tasks

Contributor Author

rashmivkulkarni commented Jun 26, 2020

@elasticmachine merge upstream

elasticmachine and others added 5 commits

June 26, 2020 15:58


          Merge branch 'master' into upgrade_assistant

9bbbdb6


          upgrade assistant role

49990b3


          Merge branch 'master' into upgrade_assistant

6a8a80d


          upgrade_assistant role

e4836c3


          upgrade assistant

eb4c3e1

Contributor Author

rashmivkulkarni commented Jul 1, 2020

@elasticmachine merge upstream

elasticmachine and others added 3 commits

July 1, 2020 10:39


          Merge branch 'master' into upgrade_assistant

d03c04f


          more debug statements to check on cloud

98927e7


          Merge branch 'upgrade_assistant' of github.com:rasroh/kibana into upg…

12ef1ef

…rade_assistant

Contributor Author

rashmivkulkarni commented Jul 2, 2020

https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-kibana-flaky-test-runner/ ( checking it on cloud)

Contributor Author

rashmivkulkarni commented Jul 6, 2020

@elasticmachine merge upstream


          Merge branch 'master' into upgrade_assistant

2a80bdb

Contributor Author

rashmivkulkarni commented Jul 6, 2020

@jloleysens - I added a bunch of sleeps and debug messages to run this on cloud. Here is the output ...https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-kibana-flaky-test-runner/42/ - this test passes with the sleep introduced. Runs fine on local. This is due to the slowness in cloud or probably a bug for the toggle ? am unsure. Can you shed some light here please ?

LeeDr commented Jul 7, 2020

@rashmivkulkarni the Jenkins job only has debug logging for failed tests. Could you temporarily take the sleeps back out and run it again. I'm assuming it will hit a failure and with the debug logging you added I think we can understand the problem better.
I noticed there's already a retry in expectDeprecationLoggingLabel() so it will retry getting the state of the toggle button until it either matches the expected state or times out.


          commented the sleeps to check toggle button

d7cc26e

Contributor Author

rashmivkulkarni commented Jul 7, 2020

@elasticmachine merge upstream

rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request


          changes for upgrade assistant functional test to incorporate test user (

667f4b2

elastic#70071)

* changes for upgrade assistant functional test to incorporate test user

* changes to toggle on/off

* upgrade_assistant role

* upgrade assistant

* more debug statements to check on cloud

* commented the sleeps to check toggle button

* reduced the sleep to 2 seconds to test on cloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

rashmivkulkarni mentioned this pull request

[7.9] changes for upgrade assistant functional test to incorporate test user (#70071) #73145

Merged

rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request


          changes for upgrade assistant functional test to incorporate test user (

2a18b5b

elastic#70071)

* changes for upgrade assistant functional test to incorporate test user

* changes to toggle on/off

* upgrade_assistant role

* upgrade assistant

* more debug statements to check on cloud

* commented the sleeps to check toggle button

* reduced the sleep to 2 seconds to test on cloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

cjcenizal mentioned this pull request

Upgrade Assistant surfaces confusing error state for deprecation logging toggle #73211

Closed

kibanamachine added the backport missing label

Contributor

kibanamachine commented Jul 27, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

LeeDr added the v7.10.0 label

Contributor

kibanamachine commented Jul 28, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

4 similar comments

Contributor

kibanamachine commented Jul 29, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Jul 30, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Jul 31, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 3, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

rashmivkulkarni added a commit that referenced this pull request


          [7.9] changes for upgrade assistant functional test to incorporate te…

e404b19

…st user (#70071) (#73145)

* changes for upgrade assistant functional test to incorporate test user (#70071)

* changes for upgrade assistant functional test to incorporate test user

* changes to toggle on/off

* upgrade_assistant role

* upgrade assistant

* more debug statements to check on cloud

* commented the sleeps to check toggle button

* reduced the sleep to 2 seconds to test on cloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Update x-pack/test/functional/config.js

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Contributor

kibanamachine commented Aug 4, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

12 similar comments

Contributor

kibanamachine commented Aug 5, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 6, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 7, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 10, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 11, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 12, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 13, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 14, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 18, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 19, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 20, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

kibanamachine commented Aug 21, 2020

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor Author

rashmivkulkarni commented Aug 21, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Aug 21, 2020

ignoring request to update branch, pull request is closed

rashmivkulkarni added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip Feature:Upgrade Assistant release_note:skip test_xpack_functional v7.9.0 v7.10.0 v8.0.0