[SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint #70079

parkiino · 2020-06-26T15:02:05Z

Duplicate Issue: #67692 Improve Endpoint data source creation and edit mode

Summary

Updates the endpoint configuration in Ingest > Configurations > Endpoint > Add Datasource, and Edit Datasource.
[Ingest Manager] Implement improved Endpoint data source creation and edit mode #70029

Screenshots
Add Datasource

Edit Datasource

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-06-26T15:02:08Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-06-26T15:02:09Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-06-26T15:02:11Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

parkiino · 2020-06-26T15:04:55Z

@hbharding screen shots of the implemented design. Please let me know if there is anything I missed or needs to be changed. Note: Adding the actual policy name that the user types in to the Datasource Name text box isn't really feasible. Once Caitlin gets back i'll probably update the text then.

paul-tavares · 2020-06-26T18:09:20Z

...tion/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx

                  />
-                </LinkToApp>
+                  <EuiSpacer />
+                  <EuiButton>


This does not seem right - to have a Button with a link inside of it.

LinkToApp is actually an extension of EuiLink and that Eui component support a type property - just use that and set it to button??

:O wait you're right!

i don't think the EuiButton styling shows up if you change the type to button tho. I guess I was trying to avoid restyling the link into a button.

paul-tavares

AAWESOME! 👍
🚀

paul-tavares · 2020-06-26T20:26:26Z

x-pack/plugins/security_solution/public/common/components/endpoint/link_to_app.tsx

  /** the app id - normally the value of the `id` in that plugin's `kibana.json`  */
  appId: string;
  /** Any app specific path (route) */
  appPath?: string;
  // eslint-disable-next-line @typescript-eslint/no-explicit-any
  appState?: any;
  onClick?: MouseEventHandler<HTMLButtonElement | HTMLAnchorElement>;
+  /** Uses an EuiButton element for styling */
+  asButton?: boolean;


kevinlog · 2020-06-26T20:37:34Z

@parkiino looks good on our end regarding save/edit endpoint datasource.

@hbharding @ph I know we wanted to collapse most things into 2 steps, is there a ticket on Ingest? I just want to make sure we're on the same page that we're only handling the Endpoint specific sections in this PR

parkiino · 2020-06-26T20:52:14Z

@kevinlog I believe @jen-huang is picking up the collapsing work

* master: (59 commits) [Lens] Fix broken test (elastic#70117) [SIEM] Import timeline fix (elastic#65448) [SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint (elastic#70079) [Telemetry] Collector Schema (elastic#64942) [Endpoint] Add Endpoint empty states for onboarding (elastic#69626) Hide unused resolver buttons (elastic#70112) [Security] `Investigate in Resolver` Timeline Integration (elastic#70111) [Discover] Improve styling of graphs in sidebar (elastic#69440) [Metrics UI] Fix EuiTheme type issue (elastic#69735) skip failing suite (elastic#70104) (elastic#70103) [ENDPOINT] Hide the Timeline Flyout while on the Management Pages (elastic#69998) [SIEM][CASE] Persist callout when dismissed (elastic#68372) [SIEM][Exceptions] - Cleaned up and updated exception list item comment structure (elastic#69532) [Maps] remove indexing state from redux (elastic#69765) Add API integration test for deleting data streams. (elastic#70020) renames SIEM to Security Solution (elastic#70070) Adding saved_objects_page in OSS (elastic#69900) [Lens] Use accordion menus in field list for available and empty fields (elastic#68871) Dynamic uiActions & license support (elastic#68507) [SIEM] Update readme for timeline apis (elastic#67038) ...

…bana into alerting/consumer-based-rbac * 'alerting/consumer-based-rbac' of github.com:gmmorris/kibana: (25 commits) [Lens] Fix broken test (elastic#70117) [SIEM] Import timeline fix (elastic#65448) [SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint (elastic#70079) [Telemetry] Collector Schema (elastic#64942) [Endpoint] Add Endpoint empty states for onboarding (elastic#69626) Hide unused resolver buttons (elastic#70112) [Security] `Investigate in Resolver` Timeline Integration (elastic#70111) [Discover] Improve styling of graphs in sidebar (elastic#69440) [Metrics UI] Fix EuiTheme type issue (elastic#69735) skip failing suite (elastic#70104) (elastic#70103) [ENDPOINT] Hide the Timeline Flyout while on the Management Pages (elastic#69998) [SIEM][CASE] Persist callout when dismissed (elastic#68372) [SIEM][Exceptions] - Cleaned up and updated exception list item comment structure (elastic#69532) [Maps] remove indexing state from redux (elastic#69765) Add API integration test for deleting data streams. (elastic#70020) renames SIEM to Security Solution (elastic#70070) Adding saved_objects_page in OSS (elastic#69900) [Lens] Use accordion menus in field list for available and empty fields (elastic#68871) Dynamic uiActions & license support (elastic#68507) [SIEM] Update readme for timeline apis (elastic#67038) ...

…datasource for endpoint (elastic#70079) [security solution][ingest]UX update for ingest manager edit/create datasource for endpoint

…datasource for endpoint (#70079) (#70213) [security solution][ingest]UX update for ingest manager edit/create datasource for endpoint Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

hbharding · 2020-06-30T16:00:28Z

Hey @parkiino apologies for the late reply (i was on vacation). This looks good to me - thanks!

kibanamachine · 2020-07-06T08:23:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 327caee
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/home_page·ts.Index Management app Home page Component templates renders the component templates tab

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:34:28]         └-: Index Management app
[00:34:28]           └-> "before all" hook
[00:34:28]           └-: Home page
[00:34:28]             └-> "before all" hook
[00:34:28]             └-> "before all" hook
[00:34:28]               │ debg navigating to indexManagement url: http://localhost:6141/app/management/data/index_management
[00:34:28]               │ debg navigate to: http://localhost:6141/app/management/data/index_management
[00:34:28]               │ proc [kibana]   log   [08:06:08.232] [info][authentication][plugins][security] Authentication attempt failed: [security_exception] unable to authenticate user [ml_poweruser] for REST request [/_security/_authenticate], with { header={ WWW-Authenticate={ 0="ApiKey" & 1="Basic realm=\"security\" charset=\"UTF-8\"" } } }
[00:34:28]               │ERROR browser[SEVERE] http://localhost:6141/app/management/data/index_management?_t=1594022768190 - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:34:28]               │ debg ... sleep(700) start
[00:34:29]               │ debg ... sleep(700) end
[00:34:29]               │ debg returned from get, calling refresh
[00:34:29]               │ debg browser[INFO] http://localhost:6141/login?next=%2Fapp%2Fmanagement%2Fdata%2Findex_management%3F_t%3D1594022768190 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:34:29]               │
[00:34:29]               │ debg browser[INFO] http://localhost:6141/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:34:29]               │ debg currentUrl = http://localhost:6141/login?next=%2Fapp%2Fmanagement%2Fdata%2Findex_management%3F_t%3D1594022768190
[00:34:29]               │          appUrl = http://localhost:6141/app/management/data/index_management
[00:34:29]               │ debg TestSubjects.find(kibanaChrome)
[00:34:29]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:34:31]               │ debg Found login page
[00:34:31]               │ debg TestSubjects.setValue(loginUsername, test_user)
[00:34:31]               │ debg TestSubjects.click(loginUsername)
[00:34:31]               │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:34:31]               │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:34:31]               │ debg browser[INFO] http://localhost:6141/34055/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T08:06:10Z
[00:34:31]               │        Adding connection to http://localhost:6141/elasticsearch
[00:34:31]               │
[00:34:31]               │      "
[00:34:31]               │ debg TestSubjects.setValue(loginPassword, changeme)
[00:34:31]               │ debg TestSubjects.click(loginPassword)
[00:34:31]               │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:34:31]               │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:34:32]               │ debg TestSubjects.click(loginSubmit)
[00:34:32]               │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:34:32]               │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:34:32]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"] nav:not(.ng-hide)') with timeout=60000
[00:34:34]               │ debg browser[INFO] http://localhost:6141/app/management/data/index_management?_t=1594022768190 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:34:34]               │
[00:34:34]               │ debg browser[INFO] http://localhost:6141/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:34:34]               │ debg browser[INFO] http://localhost:6141/34055/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T08:06:13Z
[00:34:34]               │        Adding connection to http://localhost:6141/elasticsearch
[00:34:34]               │
[00:34:34]               │      "
[00:34:35]               │ debg browser[INFO] http://localhost:6141/app/management/data/index_management?_t=1594022774151 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:34:35]               │
[00:34:35]               │ debg browser[INFO] http://localhost:6141/bundles/app/core/bootstrap.js 43:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:34:35]               │ debg Finished login process currentUrl = http://localhost:6141/app/management/data/index_management
[00:34:35]               │ debg ... sleep(501) start
[00:34:35]               │ debg ... sleep(501) end
[00:34:36]               │ debg in navigateTo url = http://localhost:6141/app/management/data/index_management
[00:34:36]               │ debg TestSubjects.exists(statusPageContainer)
[00:34:36]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:34:38]               │ debg browser[INFO] http://localhost:6141/34055/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T08:06:15Z
[00:34:38]               │        Adding connection to http://localhost:6141/elasticsearch
[00:34:38]               │
[00:34:38]               │      "
[00:34:38]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:34:39]             └-> Loads the app and renders the indices tab by default
[00:34:39]               └-> "before each" hook: global before each
[00:34:39]               │ debg Checking for section heading to say Index Management.
[00:34:39]               │ debg TestSubjects.getVisibleText(appTitle)
[00:34:39]               │ debg TestSubjects.find(appTitle)
[00:34:39]               │ debg Find.findByCssSelector('[data-test-subj="appTitle"]') with timeout=10000
[00:34:39]               │ debg TestSubjects.exists(indicesList)
[00:34:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="indicesList"]') with timeout=2500
[00:34:39]               │ debg TestSubjects.find(reloadIndicesButton)
[00:34:39]               │ debg Find.findByCssSelector('[data-test-subj="reloadIndicesButton"]') with timeout=10000
[00:34:39]               └- ✓ pass  (179ms) "Index Management app Home page Loads the app and renders the indices tab by default"
[00:34:39]             └-: Data streams
[00:34:39]               └-> "before all" hook
[00:34:42]             └-: Component templates
[00:34:42]               └-> "before all" hook
[00:34:42]               └-> renders the component templates tab
[00:34:42]                 └-> "before each" hook: global before each
[00:34:42]                 │ debg TestSubjects.click(component_templatesTab)
[00:34:42]                 │ debg Find.clickByCssSelector('[data-test-subj="component_templatesTab"]') with timeout=10000
[00:34:42]                 │ debg Find.findByCssSelector('[data-test-subj="component_templatesTab"]') with timeout=10000
[00:34:42]                 │ debg isGlobalLoadingIndicatorVisible
[00:34:42]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:34:42]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:34:42]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:34:44]                 │ debg --- retry.tryForTime failed again with the same message...
[00:34:44]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:34:44]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:34:44]                 │ debg TestSubjects.exists(emptyList)
[00:34:44]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="emptyList"]') with timeout=2500
[00:34:47]                 │ debg --- retry.tryForTime error: [data-test-subj="emptyList"] is not displayed
[00:34:47]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Index Management app Home page Component templates renders the component templates tab.png"
[00:34:48]                 │ info Current URL is: http://localhost:6141/app/management/data/index_management/component_templates
[00:34:48]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Index Management app Home page Component templates renders the component templates tab.html
[00:34:48]                 └- ✖ fail: "Index Management app Home page Component templates renders the component templates tab"
[00:34:48]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/index_management/home_page.ts:86:49)

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-optimizer/src/integration_tests.builds expected bundles, saves bundle counts to metadata

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 45 times on tracked branches: https://github.com/elastic/kibana/issues/70753

Stack Trace

Error: expected optimizer to produce two or three "running" states, states: [ { state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles: [],
       startTime: 1594023006021,
       durSec: 0 } },
  { event:
     { type: 'bundle not cached',
       reason: 'missing optimizer cache key',
       bundle:
        Bundle {
          type: 'plugin',
          id: 'bar',
          publicDirNames: [ 'public' ],
          contextDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
          sourceRoot:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
          outputDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
          cache:
           BundleCache {
             path:
              '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
             state: {} } } },
    state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 0.5 } },
  { event:
     { type: 'bundle not cached',
       reason: 'missing optimizer cache key',
       bundle:
        Bundle {
          type: 'plugin',
          id: 'foo',
          publicDirNames: [ 'public' ],
          contextDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
          sourceRoot:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
          outputDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
          cache:
           BundleCache {
             path:
              '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
             state: {} } } },
    state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 0.5 } },
  { event: { type: 'optimizer initialized' },
    state:
     { phase: 'initialized',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 0.5 } },
  { event:
     { type: 'worker started',
       bundles:
        [ Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } } ] },
    state:
     { phase: 'initialized',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 1.2 } },
  { event: { bundleId: 'foo', type: 'running' },
    state:
     { phase: 'running',
       compilerStates: [ { bundleId: 'foo', type: 'running' } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 1.5 } },
  { event: { bundleId: 'bar', type: 'running' },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'foo', type: 'running' },
          { bundleId: 'bar', type: 'running' } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 1.5 } },
  { event:
     { bundleId: 'foo', type: 'compiler success', moduleCount: 6 },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'bar', type: 'running' },
          { bundleId: 'foo', type: 'compiler success', moduleCount: 6 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 2.7 } },
  { event:
     { type: 'worker stdio',
       chunk:
        <Buffer 42 72 6f 77 73 65 72 73 6c 69 73 74 3a 20 63 61 6e 69 75 73 65 2d 6c 69 74 65 20 69 73 20 6f 75 74 64 61 74 65 64 2e 20 50 6c 65 61 73 65 20 72 75 6e ... >,
       stream: 'stderr' },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'bar', type: 'running' },
          { bundleId: 'foo', type: 'compiler success', moduleCount: 6 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 3.3 } },
  { event:
     { bundleId: 'bar', type: 'compiler success', moduleCount: 18 },
    state:
     { phase: 'success',
       compilerStates:
        [ { bundleId: 'foo', type: 'compiler success', moduleCount: 6 },
          { bundleId: 'bar', type: 'compiler success', moduleCount: 18 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1594023006021,
       durSec: 3.4 } } ]
    at assert (/dev/shm/workspace/kibana/packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts:82:13)
    at Object.<anonymous>.it (/dev/shm/workspace/kibana/packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts:108:3)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_management/templates·js.apis management index management index templates get all should list all the index templates with the expected parameters

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:04:42]           └-: management
[00:04:42]             └-> "before all" hook
[00:05:02]             └-: index management
[00:05:02]               └-> "before all" hook
[00:05:04]               └-: index templates
[00:05:04]                 └-> "before all" hook
[00:05:04]                 └-: get all
[00:05:04]                   └-> "before all" hook
[00:05:04]                   └-> should list all the index templates with the expected parameters
[00:05:04]                     └-> "before each" hook: global before each
[00:05:04]                     └-> "before each" hook
[00:05:04]                       │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594018472641591700] adding template [template-ummfwgunrnrebzsn-1594023048496] for index patterns [test*]
[00:05:04]                     └- ✖ fail: "apis management index management index templates get all should list all the index templates with the expected parameters"
[00:05:04]                     │

Stack Trace

{ Error: expected [ { name: 'logs',
    version: 0,
    priority: 100,
    indexPatterns: [ 'logs-*-*' ],
    composedOf: [ 'logs-mappings', 'logs-settings' ],
    _kbnMeta: { isManaged: false },
    hasSettings: false,
    hasAliases: false,
    hasMappings: false },
  { name: 'metrics',
    version: 0,
    priority: 100,
    indexPatterns: [ 'metrics-*-*' ],
    composedOf: [ 'metrics-mappings', 'metrics-settings' ],
    _kbnMeta: { isManaged: false },
    hasSettings: false,
    hasAliases: false,
    hasMappings: false } ] to sort of equal []
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/management/index_management/templates.js:44:43)
  actual:
   '[\n  {\n    "_kbnMeta": {\n      "isManaged": false\n    }\n    "composedOf": [\n      "logs-mappings"\n      "logs-settings"\n    ]\n    "hasAliases": false\n    "hasMappings": false\n    "hasSettings": false\n    "indexPatterns": [\n      "logs-*-*"\n    ]\n    "name": "logs"\n    "priority": 100\n    "version": 0\n  }\n  {\n    "_kbnMeta": {\n      "isManaged": false\n    }\n    "composedOf": [\n      "metrics-mappings"\n      "metrics-settings"\n    ]\n    "hasAliases": false\n    "hasMappings": false\n    "hasSettings": false\n    "indexPatterns": [\n      "metrics-*-*"\n    ]\n    "name": "metrics"\n    "priority": 100\n    "version": 0\n  }\n]',
  expected: '[]',
  showDiff: true }

and 3 more failures, only showing the first 3.

Build metrics

✅ unchanged

History

💚 Build #56881 succeeded 327caee
💔 Build #56853 failed 6bd2f89
💚 Build #56724 succeeded 7e55c41

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

UX update for ingest manager edit/create datasource for endpoint

7e55c41

parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 26, 2020

parkiino requested review from a team as code owners June 26, 2020 15:02

paul-tavares reviewed Jun 26, 2020

View reviewed changes

remove link from within button

6bd2f89

paul-tavares approved these changes Jun 26, 2020

View reviewed changes

kevinlog approved these changes Jun 26, 2020

View reviewed changes

remove unnecessary import

327caee

parkiino merged commit 684289d into elastic:master Jun 27, 2020

parkiino deleted the task/ui-endpoint-config branch June 27, 2020 00:25

parkiino mentioned this pull request Jun 29, 2020

[7.x] [SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint (#70079) #70213

Merged

hbharding mentioned this pull request Jun 30, 2020

[Ingest Manager] Implement improved Endpoint data source creation and edit mode #70029

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint #70079

[SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint #70079

parkiino commented Jun 26, 2020 •

edited by aisantos

Loading

elasticmachine commented Jun 26, 2020

elasticmachine commented Jun 26, 2020

elasticmachine commented Jun 26, 2020

parkiino commented Jun 26, 2020

paul-tavares Jun 26, 2020

parkiino Jun 26, 2020

parkiino Jun 26, 2020

paul-tavares left a comment

paul-tavares Jun 26, 2020

kevinlog commented Jun 26, 2020

parkiino commented Jun 26, 2020

hbharding commented Jun 30, 2020

kibanamachine commented Jul 6, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

[SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint #70079

[SECURITY SOLUTION][INGEST] UX update for ingest manager edit/create datasource for endpoint #70079

Conversation

parkiino commented Jun 26, 2020 • edited by aisantos Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 26, 2020

elasticmachine commented Jun 26, 2020

elasticmachine commented Jun 26, 2020

parkiino commented Jun 26, 2020

paul-tavares Jun 26, 2020

Choose a reason for hiding this comment

parkiino Jun 26, 2020

Choose a reason for hiding this comment

parkiino Jun 26, 2020

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

paul-tavares Jun 26, 2020

Choose a reason for hiding this comment

kevinlog commented Jun 26, 2020

parkiino commented Jun 26, 2020

hbharding commented Jun 30, 2020

kibanamachine commented Jul 6, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Build metrics

History

parkiino commented Jun 26, 2020 •

edited by aisantos

Loading