Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add ability to set colors for y-axis series #70311

Merged
merged 20 commits into from
Jul 3, 2020
Merged

[Lens] Add ability to set colors for y-axis series #70311

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
446eb18
axis colors
mbondyra Jun 30, 2020
9287271
refactor: don't read palette yourself
mbondyra Jun 30, 2020
8febc84
compressed picker
mbondyra Jun 30, 2020
cf54304
feat: custom color Picker
mbondyra Jul 1, 2020
6ab4f36
typecheck
mbondyra Jul 1, 2020
9aa3fca
refactoring & tests
mbondyra Jul 1, 2020
8b80ff1
removing caret-color
mbondyra Jul 1, 2020
9cf9232
aaand back to ColorPicker
mbondyra Jul 1, 2020
9f42172
expression fix
mbondyra Jul 1, 2020
4720a98
color fix
mbondyra Jul 1, 2020
6a54049
tests added to xy_expression
mbondyra Jul 1, 2020
144cf1b
types
mbondyra Jul 1, 2020
71ce160
design review
mbondyra Jul 2, 2020
a3fb6b7
types
mbondyra Jul 2, 2020
b8aa364
addressing Joe's comment
mbondyra Jul 2, 2020
81c0ba9
+memo
mbondyra Jul 2, 2020
d2179b8
Merge commit '1cfc9356bd36c54b8005089decc36970c11c101d' into lens/axi…
mbondyra Jul 2, 2020
952fa77
tooltip design change
mbondyra Jul 2, 2020
20a9a40
cr
mbondyra Jul 2, 2020
212effa
removing non existing prop
mbondyra Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import React, { useState } from 'react';
import { i18n } from '@kbn/i18n';
import { debounce } from 'lodash';
import {
EuiButtonGroup,
EuiFormRow,
Expand Down Expand Up @@ -164,7 +165,7 @@ const tooltipContent = {
}),
disabled: i18n.translate('xpack.lens.configPanel.color.tooltip.disabled', {
defaultMessage:
'Individual series cannot be custom colored when the layer includes a “Split by.“',
'Individual series cannot be custom colored when the layer includes a “Break down by“',
}),
};

Expand All @@ -182,25 +183,28 @@ const ColorPicker = ({

const handleColor: EuiColorPickerProps['onChange'] = (text, output) => {
setColor(text);

if (output.isValid || text === '') {
const newYConfigs = [...(layer.yConfig || [])];
const existingIndex = newYConfigs.findIndex((yConfig) => yConfig.forAccessor === accessor);
if (existingIndex !== -1) {
if (text === '') {
delete newYConfigs[existingIndex].color;
} else {
newYConfigs[existingIndex].color = output.hex;
}
updateColorInState(text, output);
}
};

const updateColorInState: EuiColorPickerProps['onChange'] = debounce((text, output) => {
mbondyra marked this conversation as resolved.
Show resolved Hide resolved
const newYConfigs = [...(layer.yConfig || [])];
const existingIndex = newYConfigs.findIndex((yConfig) => yConfig.forAccessor === accessor);
if (existingIndex !== -1) {
if (text === '') {
delete newYConfigs[existingIndex].color;
} else {
newYConfigs.push({
forAccessor: accessor,
color: output.hex,
});
newYConfigs[existingIndex].color = output.hex;
}
setState(updateLayer(state, { ...layer, yConfig: newYConfigs }, index));
} else {
newYConfigs.push({
forAccessor: accessor,
color: output.hex,
});
}
};
setState(updateLayer(state, { ...layer, yConfig: newYConfigs }, index));
}, 256);

return (
<EuiToolTip
Expand Down