Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolver refactoring #70312

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Resolver refactoring #70312

merged 5 commits into from
Jun 30, 2020

Commits on Jun 30, 2020

  1. remove unused piece of state

    oatkiller committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f584bd4 View commit details
    Browse the repository at this point in the history

  2. Move related event total calculation to selector 

    Also cleanup related events view code for readability
    oatkiller committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    80119f3 View commit details
    Browse the repository at this point in the history

  3. rename xscale

    oatkiller committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    e1cfb70 View commit details
    Browse the repository at this point in the history

  4. remove let 

    I find this more readable.
    oatkiller committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f4a26da View commit details
    Browse the repository at this point in the history

  5. Move dispatch call out of HTTP try-catch 

    We use try...catch for HTTP control flow logic. We don't want to treat
runtime errors the same as HTTP errors though. Move `dispatch` call
out of that try catch.
    oatkiller committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    54043fd View commit details
    Browse the repository at this point in the history