Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Jest test adjust to use relative date #70411

Merged
merged 11 commits into from
Jul 9, 2020
Merged

[Uptime] Jest test adjust to use relative date #70411

merged 11 commits into from
Jul 9, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes #70386

Adjusted jest test to use relative date to avoid test flakiness in case of render.

@shahzad31 shahzad31 requested a review from a team as a code owner July 1, 2020 09:45
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 1, 2020
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor

Snapshots are failing for me on this one.

@shahzad31
Copy link
Contributor Author

Snapshots are failing for me on this one.

@justinkambic i have updated the snapshots !!

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 1b4804b into elastic:master Jul 9, 2020
@shahzad31 shahzad31 deleted the monitor-list-failing-test branch July 9, 2020 18:57
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 13, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70411 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 mentioned this pull request Jul 14, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jul 14, 2020
@shahzad31 @elasticmachine
[Uptime] Jest test adjust to use relative date (elastic#70411)
dda9cb4 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 14, 2020
shahzad31 added a commit that referenced this pull request Jul 14, 2020
@shahzad31 @elasticmachine
[7.x] [Uptime] Jest test adjust to use relative date (#70411) (#71708)
7344246 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@brianseeders brianseeders Awaiting requested review from brianseeders

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@shahzad31 @elasticmachine @justinkambic @kibanamachine