Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC URL drilldown: trigger picker #70421

Closed
wants to merge 10 commits into from

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jul 1, 2020

Summary

URL Drilldown

spec
issue

Screenshot 2020-06-16 at 12 18 54

Jul-01-2020 16-20-24

build on top of: #68235

Highlights

  1. Nested triggers

Untitled-2020-06-18-1635-4

  1. Extension points to support url drilldown (context provider and trigger info provider)

Untitled-2020-06-18-1635-5

  1. Trigger picker

Untitled-2020-06-18-1635-6

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown..execute() & getHref navigates to correct dashboard

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: filtersFromEvent is not iterable
    at DashboardToDashboardDrilldown.getDestinationUrl (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:110:40)
    at DashboardToDashboardDrilldown.execute (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:66:38)
    at setupTestBed (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:153:21)
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:178:28)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown..execute() & getHref query is removed if filters are disabled

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: filtersFromEvent is not iterable
    at DashboardToDashboardDrilldown.getDestinationUrl (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:110:40)
    at DashboardToDashboardDrilldown.execute (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:66:38)
    at setupTestBed (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:153:21)
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:193:28)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown..execute() & getHref navigates with query if filters are enabled

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: filtersFromEvent is not iterable
    at DashboardToDashboardDrilldown.getDestinationUrl (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:110:40)
    at DashboardToDashboardDrilldown.execute (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx:66:38)
    at setupTestBed (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:153:21)
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx:210:28)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

and 15 more failures, only showing the first 3.

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
uiActionsEnhanced 64 +40 24

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants