[Ingest Manager] remove requirements component #70462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
v8.0.0
release_note:skip
|
We should update our TS type(s) to reflect the new Registry respt |
|
@neptunian Thanks for the quick turnaround to get this fixed. Lets follow up on updating the types etc. There are probably few more that need update with all the recent changes. |
|
I updated the types, tests, and examples and pushed them to jfsiii@af106c0 if you want them now, or we can use it later |
|
@elasticmachine merge upstream |
|
@jfsiii Sorry, didn't notice that. I am trying to get this passing before ruflin is done for the day because he needs to deploy the registry after this. Could you open a follow up PR? |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Jul 1, 2020
* remove requirements component * fix ts error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
neptunian
added a commit
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70453
requirementhas been replaced withconditionin the package registry. Update the UI to remove theRequirementscomponent for 7.9 and rethink how we want to handle it.